Issue metadata
Sign in to add a comment
|
Make Location bar and Omnibox use the new specs + assets |
||||||||||||||||||||||
Issue descriptionCreate Omnibox specs + assets
,
Mar 6 2018
Do you need me or stk to provide a list of what's required (like we did in the other assets bugs), or do you have that already?
,
Mar 6 2018
I think I have a pretty good idea of whats needed, but if you our stk have time, feel free to make a list.
,
Mar 6 2018
Is there any timeline as to when this can be completed?
,
Mar 20 2018
,
Mar 30 2018
The NextAction date has arrived: 2018-03-30
,
Mar 30 2018
Need to discuss some things with Stepan and he should be back in office next week, so moving next action to Tuesday.
,
Apr 3 2018
The NextAction date has arrived: 2018-04-03
,
Apr 5 2018
,
Apr 5 2018
,
Apr 9 2018
Any updates here ?
,
Apr 12 2018
,
May 9 2018
Stepan: Just wondering if you are blocked here? I know you've got some assets but I'm not sure if you've got all.
,
May 9 2018
I am currently not blocked on a lack of any assets because I have non-asset-dependent work available for a couple of weeks to come. I haven't reviewed if there are any lacking assets at this point, sorry.
,
May 18 2018
OK, now it'd be nice to have the spec. Could you please prioritize?
,
May 18 2018
,
May 18 2018
,
May 22 2018
The NextAction date has arrived: 2018-05-22
,
May 28 2018
Pinging this. I am assuming this includes also the share icon (which is currently tiny).
,
May 29 2018
In fact, I'm already using the share button icon that Pete provided. I disagree that it's tiny. :)
,
May 30 2018
The tininess issue has been addressed in Issue 829397 in comment 14 (it is too tiny and it should be set to render at 28x28pt). Other specs/assets to come...
,
May 31 2018
## Background Pill-shaped View - height: 38pt - [C x Any] width: |-12-[omnibox]-12-| - [C x C; R x Any] width <= 370 (TODO: more complete toolbar control layout) - touch-target height: 44pt - corner radius: 19pt - background color: black @ 0.1 alpha - incognito background color: white @ 0.2 alpha ## Share Button (assuming 28x28pt asset-based bounds) - image: omnibox_share*.png (https://drive.google.com/corp/drive/folders/1SCEI15MXVkeWtjrqz6LQRR3S0JhYz0bH) - vertically centered - |-[shareButton]-10-| (per comment 8 in Issue 829397) - touch-target bounds: 44x44pt - tint: black @ 0.3 alpha - incognito tint: white @ 0.5 alpha ## Security Icon (20x20pt asset-based bounds) + Origin Label/Textfield - update security icons with assets found here: https://drive.google.com/corp/drive/folders/1SCEI15MXVkeWtjrqz6LQRR3S0JhYz0bH (omnibox_connection*.png) - 2pt spacing between icon and label - both views are vertically centered - assuming icon + label in same inherit width parent view: horizontally centered - font (focused, steady, and placeholder): system (SF); 19pt; regular weight - icon tint color & font color (focused and steady): black @ 0.7 alpha - incognito icon tint color & font color (focused and steady): white - placeholder color: black @ 0.3 alpha - incognito placeholder color: white @ 0.5 alpha - focused textfield (assumed parent view is background pill-shaped rect): |-16-[textField]-4-[clearButton]-10-| - tint color (cursor): black - incognito tint color (cursor): white ## Cancel Button (C x Any) - 17pt regular - color: black @ 0.5 alpha - incognito color: white - |-12-[omnibox]-12-[cancelButton]-12-|
,
May 31 2018
,
May 31 2018
,
Jun 1 2018
,
Jun 7 2018
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f11d9bda0583758122b029b47088b18d74d068a commit 7f11d9bda0583758122b029b47088b18d74d068a Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Thu Jun 07 14:10:19 2018 [UI Refresh] Match steady location bar UI spec. Adjusts colors and spacings to match the steady location bar specs. Bug: 819235 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7ae135ed5c0e9413bdcd2f33e750abc3c2431631 Reviewed-on: https://chromium-review.googlesource.com/1082395 Reviewed-by: Elodie Banel <lod@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565254} [modify] https://crrev.com/7f11d9bda0583758122b029b47088b18d74d068a/ios/chrome/browser/ui/location_bar/location_bar_steady_view.h [modify] https://crrev.com/7f11d9bda0583758122b029b47088b18d74d068a/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm [modify] https://crrev.com/7f11d9bda0583758122b029b47088b18d74d068a/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
,
Jun 8 2018
This is mostly complete, some follow-up is necessary for the placeholder.
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be6dfe645d947d3da18d331356744e9479cd18a4 commit be6dfe645d947d3da18d331356744e9479cd18a4 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Wed Jun 13 17:51:13 2018 [UIRefresh] Update the omnibox placeholder color. Updates the font ant placeholder colors to match mocks. Bug: 819235 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2cb5b83c79c0240119646cb5e53a6acdb2e1adf0 Reviewed-on: https://chromium-review.googlesource.com/1098957 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#566900} [modify] https://crrev.com/be6dfe645d947d3da18d331356744e9479cd18a4/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm [modify] https://crrev.com/be6dfe645d947d3da18d331356744e9479cd18a4/ios/chrome/browser/ui/omnibox/omnibox_coordinator.mm [modify] https://crrev.com/be6dfe645d947d3da18d331356744e9479cd18a4/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e4214a466280060d21a38a5f124c912a04126e5 commit 5e4214a466280060d21a38a5f124c912a04126e5 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Thu Jun 14 11:06:39 2018 [UIRefresh] Tint leading image view of omnibox. Adds a tint to the leading image view, and moves color- and font-related code from coordinator to view controller. Bug: 819235 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd9c6f54d6d8b6e35eb9bc4803b42a3dbfd0bbf6 Reviewed-on: https://chromium-review.googlesource.com/1099380 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#567219} [modify] https://crrev.com/5e4214a466280060d21a38a5f124c912a04126e5/ios/chrome/browser/ui/omnibox/omnibox_container_view.h [modify] https://crrev.com/5e4214a466280060d21a38a5f124c912a04126e5/ios/chrome/browser/ui/omnibox/omnibox_container_view.mm [modify] https://crrev.com/5e4214a466280060d21a38a5f124c912a04126e5/ios/chrome/browser/ui/omnibox/omnibox_coordinator.mm [modify] https://crrev.com/5e4214a466280060d21a38a5f124c912a04126e5/ios/chrome/browser/ui/omnibox/omnibox_view_controller.h [modify] https://crrev.com/5e4214a466280060d21a38a5f124c912a04126e5/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
,
Jun 14 2018
Leftover work is tracked in 852787. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pschaffner@chromium.org
, Mar 6 2018Labels: OS-iOS