New issue
Advanced search Search tips

Issue 819218 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 781765



Sign in to add a comment

Record UMA to discover whether EventLogger is always initialized

Project Member Reported by dullweber@chromium.org, Mar 6 2018

Issue description

Record a histogram from ConsentAuditor if EventLogger is not ready to record events when a consent should be recorded.
 
Components: Privacy
Blocking: 781765

Comment 3 Deleted

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60a1529368cce611295b8363bb0f2d1c7beb2386

commit 60a1529368cce611295b8363bb0f2d1c7beb2386
Author: Christian Dullweber <dullweber@chromium.org>
Date: Tue Mar 06 23:21:25 2018

Add histogram to record whether UserEventService is ready

Record whether the UserEventService is ready when a consent is recorded.
This should always be true as the service is created on startup.

Bug:  819218 
Change-Id: I3ea4e7574d100d3fb7f6746172e8bb10b5be0f06
Reviewed-on: https://chromium-review.googlesource.com/951482
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541237}
[modify] https://crrev.com/60a1529368cce611295b8363bb0f2d1c7beb2386/components/consent_auditor/consent_auditor.cc
[modify] https://crrev.com/60a1529368cce611295b8363bb0f2d1c7beb2386/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-66
The CL above adds a histogram to M66 consent auditor that will be used to inform further development of the feature in M67. Requesting a merge.
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 8 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 8 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63438275f6f15b0a0fef74c82aea0e5d8a69e622

commit 63438275f6f15b0a0fef74c82aea0e5d8a69e622
Author: Christian Dullweber <dullweber@chromium.org>
Date: Thu Mar 08 11:50:19 2018

Add histogram to record whether UserEventService is ready

Record whether the UserEventService is ready when a consent is recorded.
This should always be true as the service is created on startup.

Bug:  819218 
Change-Id: I3ea4e7574d100d3fb7f6746172e8bb10b5be0f06
Reviewed-on: https://chromium-review.googlesource.com/951482
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541237}(cherry picked from commit 60a1529368cce611295b8363bb0f2d1c7beb2386)
Reviewed-on: https://chromium-review.googlesource.com/955442
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#91}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/63438275f6f15b0a0fef74c82aea0e5d8a69e622/components/consent_auditor/consent_auditor.cc
[modify] https://crrev.com/63438275f6f15b0a0fef74c82aea0e5d8a69e622/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
We should monitor Privacy.ConsentAuditor.UserEventServiceReady and check if it works correctly on all platforms.

Sign in to add a comment