New issue
Advanced search Search tips

Issue 819204 link

Starred by 1 user
Status: Fixed
Owner:
jlebel@chromium.org
Closed: Mar 2018
Cc:
msramek@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocking:
issue 781765



Sign in to add a comment

Record important consent moments for iOS

Project Member Reported by jlebel@chromium.org, Mar 6 2018 
This bug is for iOS implementation of issue 781765:
For features that require a user consent in order to be enabled, recording the text of the consent moment (and not just the boolean enabled/disabled) will allow us to discover and address cases when the text was incorrect, mistranslated, etc.

Comment 1 by jlebel@chromium.org, Mar 6 2018

Labels: OS-iOS
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9

commit f25747e5aedfc86fdb3ea8da94d14ab0c76374c9
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Tue Mar 06 13:27:39 2018

Recording user consent on iOS in the sync confirmation dialog

https://drive.google.com/open?id=1lm9YtGCZFxd7HyLdG4omPWoJy6R7Dg5i

When the user accepts the sync confirmation, all the string ids need
to be recorded using ConsentAuditor::RecordGaiaConsent().

See detailed explanation in this (internal) doc:
https://docs.google.com/document/d/1Psl9VJ4Dbc1Dh5bXCTa85OF1_DE3viTTHYwybu3V6Uk/edit#bookmark=id.6zygb41dn9vl

Related patch:
crrev.com/c/897948
crrev.com/c/880861

Bug:  819204 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6b4cba87e495af6a7d96e1428b6737e547ecf49f
Reviewed-on: https://chromium-review.googlesource.com/924033
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541089}
[modify] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/components/consent_auditor/consent_auditor.cc
[modify] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/browser_state/BUILD.gn
[modify] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
[add] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/consent_auditor/BUILD.gn
[add] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/consent_auditor/DEPS
[add] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/consent_auditor/OWNERS
[add] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/consent_auditor/consent_auditor_factory.cc
[add] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/consent_auditor/consent_auditor_factory.h
[modify] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/ui/authentication/BUILD.gn
[add] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/ui/authentication/DEPS
[modify] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.h
[modify] https://crrev.com/f25747e5aedfc86fdb3ea8da94d14ab0c76374c9/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm

Comment 3 Deleted

Comment 4 by jlebel@chromium.org, Mar 6 2018

Status: Fixed (was: Started)

Comment 5 by jlebel@chromium.org, Mar 6 2018

Labels: Merge-Request-66
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 6 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by jlebel@chromium.org, Mar 6 2018 

I would need to merge this patch to M-66 for GDPR. This patch will be followed by  issue 819176 .

Comment 8 by cmasso@google.com, Mar 7 2018

Labels: -Hotlist-Merge-Review -Merge-Review-66 Merge-Approved-66
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 7 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/640eb24d0f0b9c9c4269530cc99b974bd91c673f

commit 640eb24d0f0b9c9c4269530cc99b974bd91c673f
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Wed Mar 07 19:57:03 2018

Recording user consent on iOS in the sync confirmation dialog

https://drive.google.com/open?id=1lm9YtGCZFxd7HyLdG4omPWoJy6R7Dg5i

When the user accepts the sync confirmation, all the string ids need
to be recorded using ConsentAuditor::RecordGaiaConsent().

See detailed explanation in this (internal) doc:
https://docs.google.com/document/d/1Psl9VJ4Dbc1Dh5bXCTa85OF1_DE3viTTHYwybu3V6Uk/edit#bookmark=id.6zygb41dn9vl

Related patch:
crrev.com/c/897948
crrev.com/c/880861

Bug:  819204 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6b4cba87e495af6a7d96e1428b6737e547ecf49f
Reviewed-on: https://chromium-review.googlesource.com/924033
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541089}(cherry picked from commit f25747e5aedfc86fdb3ea8da94d14ab0c76374c9)
Reviewed-on: https://chromium-review.googlesource.com/953462
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#71}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/components/consent_auditor/consent_auditor.cc
[modify] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/browser_state/BUILD.gn
[modify] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
[add] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/consent_auditor/BUILD.gn
[add] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/consent_auditor/DEPS
[add] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/consent_auditor/OWNERS
[add] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/consent_auditor/consent_auditor_factory.cc
[add] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/consent_auditor/consent_auditor_factory.h
[modify] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/prefs/BUILD.gn
[modify] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/ui/authentication/BUILD.gn
[add] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/ui/authentication/DEPS
[modify] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[modify] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.h
[modify] https://crrev.com/640eb24d0f0b9c9c4269530cc99b974bd91c673f/ios/chrome/browser/ui/authentication/signin_confirmation_view_controller.mm
►

Sign in to add a comment