Issue metadata
Sign in to add a comment
|
[iOS] DCHECK failing on IsTrackingMetadata() in ConsentAuditor::RecordGaiaConsent() |
||||||||||||||||||||||||
Issue descriptionOn iOS, IsTrackingMetadata() might returns false when ConsentAuditor::RecordGaiaConsent() is called. This makes the DCHECK failing. ConsentAuditor::RecordGaiaConsent() is called when the user validates the sync confirmation dialog. Related to crbug.com/709094 , crbug.com/761485 .
,
Mar 6 2018
,
Mar 6 2018
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f2f87fa8c9ac5aed5b0e46fe1e62fbb160321e7 commit 1f2f87fa8c9ac5aed5b0e46fe1e62fbb160321e7 Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Mar 06 16:48:52 2018 [iOS] Should create IOSUserEventService as soon as possible IOSUserEventService is not synchronous. To avoid to have the DCHECK in ConsentAuditor::RecordGaiaConsent() failing, this service should be created as soon as possible, to make sure it is correctly initialized before using it. With this fix, it is now possible to put back the DCHECK in ConsentAuditor::RecordGaiaConsent(). Bug: 819176 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I66be7843eb3cc73686c07b0ffdee232c90dad7dd Reviewed-on: https://chromium-review.googlesource.com/951484 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#541123} [modify] https://crrev.com/1f2f87fa8c9ac5aed5b0e46fe1e62fbb160321e7/components/consent_auditor/consent_auditor.cc [modify] https://crrev.com/1f2f87fa8c9ac5aed5b0e46fe1e62fbb160321e7/ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc
,
Mar 6 2018
,
Mar 6 2018
I would need to merge this patch to M-66 for GDPR. This patch will be followed by issue 819204 .
,
Mar 7 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7e5331e50ee7957e45ea069bcd612cab4c9eada commit b7e5331e50ee7957e45ea069bcd612cab4c9eada Author: Jérôme Lebel <jlebel@chromium.org> Date: Wed Mar 07 20:02:03 2018 [iOS] Should create IOSUserEventService as soon as possible IOSUserEventService is not synchronous. To avoid to have the DCHECK in ConsentAuditor::RecordGaiaConsent() failing, this service should be created as soon as possible, to make sure it is correctly initialized before using it. With this fix, it is now possible to put back the DCHECK in ConsentAuditor::RecordGaiaConsent(). Bug: 819176 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I66be7843eb3cc73686c07b0ffdee232c90dad7dd Reviewed-on: https://chromium-review.googlesource.com/951484 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541123}(cherry picked from commit 1f2f87fa8c9ac5aed5b0e46fe1e62fbb160321e7) Reviewed-on: https://chromium-review.googlesource.com/953463 Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#72} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/b7e5331e50ee7957e45ea069bcd612cab4c9eada/components/consent_auditor/consent_auditor.cc [modify] https://crrev.com/b7e5331e50ee7957e45ea069bcd612cab4c9eada/ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by msramek@chromium.org
, Mar 6 2018Labels: -Pri-3 Pri-1
Status: Assigned (was: Available)