New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819175 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Email to this user bounced
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0.2% regression in sizes at 540928:540928

Project Member Reported by rmcilroy@chromium.org, Mar 6 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=819175

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=38c8278061ee1d6993b0de9a508dc6cabbc81e98aa445ca644dd49531ec20ccf


Bot(s) for this bug's original alert(s):

linux
Status: Assigned (was: Untriaged)
Assigning to angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com because this is the only CL in range:
Roll src/third_party/angle/ 78e39b3fd..f0e89be69 (4 commits)

https://chromium.googlesource.com/angle/angle.git/+log/78e39b3fd675..f0e89be69906

$ git log 78e39b3fd..f0e89be69 --date=short --no-merges --format='%ad %ae %s'
2017-11-08 cwallez Use packed enums for the texture types and targets, part 1
2018-02-08 oetuaho Statically allocate built-in function symbols
2018-03-05 oetuaho Last case in switch statement can't be empty in ESSL 3.10
2018-02-28 jmadill Vulkan: Fix Texture attachment state changes.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I2b7bfee876909857d925aaf205198b57a20e5b36
Reviewed-on: https://chromium-review.googlesource.com/949662
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540928}
Owner: ynovikov@chromium.org
Reassigning to sheriff ynovikov@chromium.org -- It looks like one of the CLs in this angle roll increased linux binary size by 240KiB. Can you help triage?
Cc: ynovikov@chromium.org
Owner: jmad...@chromium.org
I suspect this is https://chromium-review.googlesource.com/924155.
Jamie, do you think this increase is justified?
Owner: oetu...@nvidia.com
Reassigning to author oetuaho. I think the size is justified - it's moving runtime initialization into static initialization. Olli can confirm if it's so. Presumably this is not from extra code gen, but from data.
Cc: jmad...@chromium.org

Comment 7 by oetu...@nvidia.com, Mar 20 2018

Status: WontFix (was: Assigned)
This change made the ANGLE shader compiler initialization take around 50% less time, and it has also made it possible to reduce runtime memory use. It was known that this was a tradeoff with binary size.

I've also already done a bit of further work on the code to bring the binary size down again, and still have some ideas how to mitigate this binary size increase further. We can't get rid of the increased binary size entirely, but it's reasonable considering the benefits.

Sign in to add a comment