Issue metadata
Sign in to add a comment
|
0.2% regression in sizes at 540928:540928 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 6 2018
Assigning to angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com because this is the only CL in range: Roll src/third_party/angle/ 78e39b3fd..f0e89be69 (4 commits) https://chromium.googlesource.com/angle/angle.git/+log/78e39b3fd675..f0e89be69906 $ git log 78e39b3fd..f0e89be69 --date=short --no-merges --format='%ad %ae %s' 2017-11-08 cwallez Use packed enums for the texture types and targets, part 1 2018-02-08 oetuaho Statically allocate built-in function symbols 2018-03-05 oetuaho Last case in switch statement can't be empty in ESSL 3.10 2018-02-28 jmadill Vulkan: Fix Texture attachment state changes. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2b7bfee876909857d925aaf205198b57a20e5b36 Reviewed-on: https://chromium-review.googlesource.com/949662 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540928}
,
Mar 16 2018
Reassigning to sheriff ynovikov@chromium.org -- It looks like one of the CLs in this angle roll increased linux binary size by 240KiB. Can you help triage?
,
Mar 16 2018
I suspect this is https://chromium-review.googlesource.com/924155. Jamie, do you think this increase is justified?
,
Mar 16 2018
Reassigning to author oetuaho. I think the size is justified - it's moving runtime initialization into static initialization. Olli can confirm if it's so. Presumably this is not from extra code gen, but from data.
,
Mar 16 2018
,
Mar 20 2018
This change made the ANGLE shader compiler initialization take around 50% less time, and it has also made it possible to reduce runtime memory use. It was known that this was a tradeoff with binary size. I've also already done a bit of further work on the code to bring the binary size down again, and still have some ideas how to mitigate this binary size increase further. We can't get rid of the increased binary size entirely, but it's reasonable considering the benefits. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 6 2018