New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819138 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
hobby only
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 817292



Sign in to add a comment

Add a missing test for passwords settings on Android

Project Member Reported by vabr@chromium.org, Mar 6 2018

Issue description

This was listed in manual scenarios by our great QA team, but we can actually automate it:

* Blacklisted passwords ("Never save") are not part of the exported data.
 

Comment 1 by vabr@chromium.org, Mar 20 2018

CL in review at https://crrev.com/c/971101
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae2182d7c6cb701aacf96beb4a8f13557a2bd6e

commit 3ae2182d7c6cb701aacf96beb4a8f13557a2bd6e
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Mar 21 14:47:21 2018

Test that blacklisted passwords are not exported

This CL adds a unit test for PasswordManagerPresenter (which provides
passwords for exporting on desktop and Android), checking that
blacklisted passwords are not included among those being exported.

Bug:  819138 
Change-Id: Ia63eac7abc20179c3f2775186bf11cefdd36f86a
Reviewed-on: https://chromium-review.googlesource.com/971101
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544695}
[modify] https://crrev.com/3ae2182d7c6cb701aacf96beb4a8f13557a2bd6e/chrome/browser/ui/passwords/password_manager_presenter_unittest.cc

Comment 3 by vabr@chromium.org, Mar 21 2018

Status: Fixed (was: Assigned)

Comment 4 by vabr@chromium.org, Mar 22 2018

Labels: -Type-Bug Type-Task

Sign in to add a comment