DTMF sender sends first tone too quickly |
|||
Issue descriptionAccording to spec, the DTMF sender should send the first tone in a queued task. Chrome will send the first tone immediately, before InsertDTMF returns. Spec: http://w3c.github.io/webrtc-pc/#rtcdtmfsender Failing test: RTCDTMFSender-insertDTMF
,
Mar 6 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/1e0c804f1976456600264fba57e6f468e6160185 commit 1e0c804f1976456600264fba57e6f468e6160185 Author: Harald Alvestrand <hta@webrtc.org> Date: Tue Mar 06 13:23:11 2018 Make DTMF sender wait before sending the first tone. This is according to WebRTC spec. Bug: chromium:819118 Change-Id: I4c0c8e69de812730f9f5c0a1b86d08cf05a472ad Reviewed-on: https://webrtc-review.googlesource.com/60181 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22309} [modify] https://crrev.com/1e0c804f1976456600264fba57e6f468e6160185/pc/dtmfsender.cc [modify] https://crrev.com/1e0c804f1976456600264fba57e6f468e6160185/pc/dtmfsender_unittest.cc
,
Mar 7 2018
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/caeb7aedfb5d7fa8bfca515bd80cb0f833909d70 commit caeb7aedfb5d7fa8bfca515bd80cb0f833909d70 Author: Harald Alvestrand <hta@chromium.org> Date: Wed Mar 07 09:41:29 2018 Rebase and enable fixed DTMF tests Two FAIL -> PASS transitions. Bug: chromium:819118 Change-Id: Icbf845ac70ee1dbc4838e16a71ef1c2864c2c2ed Reviewed-on: https://chromium-review.googlesource.com/952902 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#541393} [modify] https://crrev.com/caeb7aedfb5d7fa8bfca515bd80cb0f833909d70/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/caeb7aedfb5d7fa8bfca515bd80cb0f833909d70/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-insertDTMF.https-expected.txt [modify] https://crrev.com/caeb7aedfb5d7fa8bfca515bd80cb0f833909d70/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCDTMFSender-ontonechange.https-expected.txt
,
Mar 7 2018
Issue 818646 has been merged into this issue.
,
Mar 9 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Mar 6 2018