The AEC3 suppressor gain rampup behavior is the same for call start and resets within the call |
||||||
Issue descriptionWhen there glitches in the audio paths the current scheme for smooth echo suppression rampup partially fails in the sense that the behavior for the initial part of the call is applied at each reset, instead of having separate behaviors during resets due to audio glitches and during the call start. This issue may have significant impact on the echo removal of when headsets are used.
,
Mar 13 2018
,
Mar 13 2018
Has this been verified in Canary?
,
Mar 13 2018
Yes, this has been running in Canary for about 5 days and the stats look good.
,
Mar 14 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 15 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/18309a648c45e759d84e4aecc938fb5cf46f8487 commit 18309a648c45e759d84e4aecc938fb5cf46f8487 Author: Per Åhgren <peah@webrtc.org> Date: Thu Mar 15 12:52:43 2018 Merge to M66: Separating the AEC3 suppressor gain rampup behavior for... This CL introduces a different rampup behavir for the call startup and after resets that may occur due to delay changes, clock-drift and audio path glitches. (cherry picked from commit 12eb85881c865a67be07d04856383fea22890d6a) TBR: gustaf@webrtc.org,devicentepena@webrtc.org,henrik.lundin@webrtc.org Bug: chromium:819111 , webrtc:8979 Change-Id: Ied1d7896be7f0c69aa6deb61475117021ca6ab09 Reviewed-on: https://webrtc-review.googlesource.com/60002 Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Original-Commit-Position: refs/heads/master@{#22312} Reviewed-on: https://webrtc-review.googlesource.com/62061 Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/branch-heads/66@{#7} Cr-Branched-From: 12c8110e8c717b7f0f87615d3b99caac2a69fa6c-refs/heads/master@{#22215} [modify] https://crrev.com/18309a648c45e759d84e4aecc938fb5cf46f8487/modules/audio_processing/aec3/BUILD.gn [modify] https://crrev.com/18309a648c45e759d84e4aecc938fb5cf46f8487/modules/audio_processing/aec3/aec_state.cc [modify] https://crrev.com/18309a648c45e759d84e4aecc938fb5cf46f8487/modules/audio_processing/aec3/aec_state.h [add] https://crrev.com/18309a648c45e759d84e4aecc938fb5cf46f8487/modules/audio_processing/aec3/suppression_gain_limiter.cc [add] https://crrev.com/18309a648c45e759d84e4aecc938fb5cf46f8487/modules/audio_processing/aec3/suppression_gain_limiter.h
,
Mar 15 2018
,
Mar 16 2018
merged, removing label |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 6 2018