Chromium Dash Feedback - "Source Tree" links to commit, not source tree |
|||
Issue descriptionWhen viewing a commit page, the "Source Tree" field shows the commit hash (and links to the commit). Linking to the commit is the right thing to do, but the field should be labelled "Commit", not "Source Tree". A commit *points* to a tree. The tree has its own hash. Normally we refer to commits by their commit hash, not the hash of the tree they point to. Because "tree" has a specific meaning in Git, calling the commit the "Source Tree" is misleading/confusing. Example: https://chromiumdash.appspot.com/commit/97d530585734b72cf709485a286b4d7ebe0595a0 Expected: "Commit 97d530" Actual: "Source Tree 97d530" The field links to https://chromium.googlesource.com/chromium/src.git/+/97d530585734b72cf709485a286b4d7ebe0595a0 which is the actual commit. You'll notice there's a "tree" field in the commit metadata, which has a different hash.
,
Apr 4 2018
I agree that Source Tree might get confused with "tree" meaning in Git, but I'm bit hesitant to rename this as Commit. In the URL path, "commit" is already used that provides information about a particular commit. How about renaming "Source Tree" - > "Gitiles link" or "Gitiles"?
,
Apr 4 2018
,
Apr 5 2018
If anything, I'd rather make the commit hash *more* prominent. Yes, the page title is "Commit", but there's a bunch of information on the page. The identifier for the commit is the 7th field in the 2nd section and is called "Source Tree". So it's not clear that this hash is actually the commit hash.
,
Jul 10
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/298709b6b4e7e4fd00035f81f923750786646013 commit 298709b6b4e7e4fd00035f81f923750786646013 Author: Prasad Vuppalapu <prasadv@google.com> Date: Tue Jul 10 23:15:13 2018
,
Jul 12
Fixed after PS referenced in c#5 (though not deployed to prod just yet, it'll occur in next few weeks).
,
Jul 12
|
|||
►
Sign in to add a comment |
|||
Comment 1 by amineer@chromium.org
, Mar 16 2018