Add MRUIndex and TotalTabCount to tab's ForegroundedOrClosed UKM |
|||||
Issue descriptionThese will help us compare an ML model for tab discarding with the current tab discarder, and are important metrics in themselves. They landed just after the branch (commit 03c6ca2285a0c0ccf06dcdcf7c0cb5858269429c) so we'd like to merge them in to 66. Waiting until 67 means another 6 weeks before we can collect data, and prevents these features from being part of the shipping model. Commit was documented in the parent bug at https://bugs.chromium.org/p/chromium/issues/detail?id=784639#c21.
,
Mar 7 2018
,
Mar 7 2018
,
Mar 8 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 8 2018
Pls merge your change to M66 branch 3359 ASAP so we can pick it up for next dev release. Thank you.
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/069d6c135f57b8123e82918d2b915c7978d5a104 commit 069d6c135f57b8123e82918d2b915c7978d5a104 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Thu Mar 08 07:23:08 2018 Add MRUIndex to tab's ForegroundedOrClosed UKM When a backgrounded tab is foregrounded or closed, include its MRU index in the ForegroundedOrClosed event. Also include the total tab count since the MRU index will range from 0 to TotalTabCount. This index is based on when the tab was most recently shown or, if it was already the active tab in its tabstrip, when its window was mostly recently activated. This way, whether switching between tabs in a tabstrip or switching between multiple windows, the foremost tab is always considered the most recently used. These are some of the last features left for tab discarding ML. TBR=bmcquade@chromium.org,fdoray@chromium.org Bug: 819092 Change-Id: I326dd15c4e66cb6c0b8361d1365b0a11cf74ba4b Reviewed-on: https://chromium-review.googlesource.com/943541 Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540577}(cherry picked from commit 03c6ca2285a0c0ccf06dcdcf7c0cb5858269429c) Reviewed-on: https://chromium-review.googlesource.com/954589 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#87} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/069d6c135f57b8123e82918d2b915c7978d5a104/chrome/browser/resource_coordinator/tab_activity_watcher.cc [modify] https://crrev.com/069d6c135f57b8123e82918d2b915c7978d5a104/chrome/browser/resource_coordinator/tab_activity_watcher.h [modify] https://crrev.com/069d6c135f57b8123e82918d2b915c7978d5a104/chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc [modify] https://crrev.com/069d6c135f57b8123e82918d2b915c7978d5a104/chrome/browser/resource_coordinator/tab_activity_watcher_unittest.cc [modify] https://crrev.com/069d6c135f57b8123e82918d2b915c7978d5a104/chrome/browser/resource_coordinator/tab_metrics_logger.cc [modify] https://crrev.com/069d6c135f57b8123e82918d2b915c7978d5a104/chrome/browser/resource_coordinator/tab_metrics_logger.h [modify] https://crrev.com/069d6c135f57b8123e82918d2b915c7978d5a104/tools/metrics/ukm/ukm.xml |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by michae...@chromium.org
, Mar 6 2018