New issue
Advanced search Search tips

Issue 819087 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 738210



Sign in to add a comment

mash: Remove InputMethodManager access from ash/login/ui

Project Member Reported by shend@chromium.org, Mar 6 2018

Issue description

There are still a couple of direct calls to InputMethodManager in ash/login/ui. Under mash, InputMethodManager will not be available from ash/login/ui, so we'll need to use Mojo instead.

[1] https://cs.chromium.org/search/?q=InputMethodManager+file:%5Esrc/ash/login/ui/+package:%5Echromium$&type=cs
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7db1603cfc85057bc40b44f40fa92ac945bdf407

commit 7db1603cfc85057bc40b44f40fa92ac945bdf407
Author: Darren Shen <shend@chromium.org>
Date: Tue Mar 06 21:02:33 2018

mash: Replace InputMethodManager calls in ash/login/ui with Mojo.

There are still a couple of direct calls to InputMethodManager in
ash/login/ui. Under mash, InputMethodManager will not be available from
ash/login/ui, so we'll need to use Mojo instead.

We replace calls to InputMethodManager with calls to the existing
ImeController::IsCapsLockEnabled() and ImeController::Observer code.

Bug:  819087 
Change-Id: I7d0b351cf4fac1b11acb1b15f3f4d804f3d581c4
Reviewed-on: https://chromium-review.googlesource.com/950582
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541190}
[modify] https://crrev.com/7db1603cfc85057bc40b44f40fa92ac945bdf407/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/7db1603cfc85057bc40b44f40fa92ac945bdf407/ash/login/ui/login_password_view.cc
[modify] https://crrev.com/7db1603cfc85057bc40b44f40fa92ac945bdf407/ash/login/ui/login_password_view.h

Comment 2 by shend@chromium.org, Mar 6 2018

Status: Fixed (was: Assigned)

Sign in to add a comment