New issue
Advanced search Search tips

Issue 819081 link

Starred by 1 user
Status: Fixed
Owner:
shend@chromium.org
Closed: Mar 2018
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 738210



Sign in to add a comment

mash: Remove InputMethodManager access from ash/accelerators/accelerator_controller.cc

Project Member Reported by shend@chromium.org, Mar 6 2018 
In ash/accelerators/accelerator_controller, we need to query / set the caps lock state (e.g. [1]). This is currently done directly through InputMethodManager.

However, under mash, InputMethodManager will not be available from accelerator_controller, so we'll need to query / set the caps lock state via Mojo.

[1] https://cs.chromium.org/chromium/src/ash/accelerators/accelerator_controller.cc?sq=package:chromium&dr&q=ash/accelerators/accelerator_controller.cc&l=602
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f63661010697dd3dd3485502634f33e86ec161f

commit 9f63661010697dd3dd3485502634f33e86ec161f
Author: Darren Shen <shend@chromium.org>
Date: Thu Mar 08 00:02:39 2018

mash: Set caps lock in ash accelerator_controller via Mojo ImeController

In ash/accelerators/accelerator_controller, we need to query / set the
caps lock state. This is currently done through InputMethodManager.

Under mash, InputMethodManager will not be available from
accelerator_controller, so we'll need to query / set the caps lock state
via Mojo.

We use the existing ImeController::IsCapsLockEnabled() and
ImeController::SetCapsLockFromTray (renamed to SetCapsLockEnabled)
methods.

Bug:  819081 
Change-Id: Id4b4337f6cb9268116b4c6bb034ad4004a3a7705
Reviewed-on: https://chromium-review.googlesource.com/950503
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541647}
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/BUILD.gn
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/ime/ime_controller.cc
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/ime/ime_controller.h
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/ime/ime_controller_unittest.cc
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/ime/test_ime_controller.cc
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/ime/test_ime_controller.h
[add] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/ime/test_ime_controller_client.cc
[add] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/ime/test_ime_controller_client.h
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/public/interfaces/ime_controller.mojom
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/ash/system/tray_caps_lock.cc
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/chrome/browser/ui/ash/ime_controller_client.cc
[modify] https://crrev.com/9f63661010697dd3dd3485502634f33e86ec161f/chrome/browser/ui/ash/ime_controller_client.h

Comment 2 by shend@chromium.org, Mar 8 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment