New issue
Advanced search Search tips

Issue 819079 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Rename components/safe_browsing/common

Project Member Reported by jialiul@chromium.org, Mar 6 2018 
"common" implies this directly should not depends on anything on content/.  That is not true for components/safe_browsing/common. We might consider either rename components/safe_browsing/common directory, or move related files to components/safe_browsing/browser or components/safe_browsing/

Comment 1 by jialiul@chromium.org, Mar 6 2018

Status: WontFix (was: Available)
Quoted from sdefresne@,
"Usually for components, "common" means code that can be used by both "renderer" and "browser" (similar to chrome/common, chrome/renderer and chrome/browser).

When component is layered, then you have "components/$foo/core" that cannot depends on content, and "components/$foo/content" that can (and "components/$foo/web" for code allowed to depends on ios/web). Both those directories can have "common"/"renderer"/"browser" sub-directories if code can be used only by renderer/browser or both.

"""
Therefore, there's no need to change the directory arrangement.
►

Sign in to add a comment