New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 819077 link

Starred by 1 user
Status: Fixed
Owner:
█ jrbarnette@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
englab-sys-cros@google.com
ayatane@chromium.org
pprabhu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 632751



Sign in to add a comment

repair_test and deployment_test ignore the --upload/--noupload options

Reported by jrbarnette@chromium.org, Mar 6 2018 
The repair_test and deployment_test command include options
--upload and --noupload intended to enable or disable upload
of logs of the command to googlestorage.  Moreover, the default
of this option is supposed to be different based on whether
it's repair_test (default="noupload") or deployment_test
(default="upload").

All of this is for naught:  Once the argument is recorded and
stored in the Namespace object, it's never consulted in the
code that actually does the upload:  the upload happens
unconditionally.  D'oh!
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6ef42f5037e815bdeecaa1bfdbcc78b4094d1b37

commit 6ef42f5037e815bdeecaa1bfdbcc78b4094d1b37
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Wed Mar 07 04:19:19 2018

[autotest] Fix --noupload for `repair_test`

The --noupload option was being ignored by the `repair_test` and
`deployment_test` commands.  This fixes the upload code to actually
check the flag before performing any upload.

BUG= chromium:819077 
TEST=`repair_test -n`, among other invocations

Change-Id: Ieebcccfdcf46dca48d9fdfd89cf32cf4f3f24b32
Reviewed-on: https://chromium-review.googlesource.com/950474
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/6ef42f5037e815bdeecaa1bfdbcc78b4094d1b37/site_utils/deployment/install.py

Comment 2 by jrbarnette@chromium.org, Mar 7 2018

Status: Fixed (was: Started)
►

Sign in to add a comment