New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 819047 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Refactor by_user flag of RemoveNotification

Project Member Reported by tetsui@chromium.org, Mar 6 2018

Issue description

MessageCenter::RemoveNotification and MessageCenterObserver::OnNotificationRemoved have a boolean argument |by_user|.

|by_user| is not granular enough, and the meaning is ambiguous. Also it's not documented.

Suggested in the CL https://crrev.com/c/882622 :

> It might also make sense for RemoveNotification/OnNotificationRemoved to have an Event* param instead of |by_user|, which is apparently not granular enough.
> you can give the event a default value of nullptr so that the majority of callsites don't have this distracting "false /* by_user */".

Yoshiki also mentioned offline that it was on his potential improvement list.
 
Status: Archived (was: Assigned)

Sign in to add a comment