Immersive mode appearing in VR tests on K |
||||
Issue descriptionWebVrTransitionTest#testRequestPresentEntersVr and testRequestSessionEntersVr are flaky due to the immersive mode popup being drawn over the screen on K. This is flaky instead of failing all the time because in most cases, we can perform the failing check fast enough that the popup has not been drawn yet. This doesn't seem to be an issue on L where the immersive mode popup also exists, although whether that's because something is causing us to reliably check before the popup is drawn or because the popup is actually disabled is unknown. This is very similar to Issue 710624 , and by extension, Issue 711035. Those were fixed by setting anr_show_background to false during provisioning, which seemed to prevent the immersive mode popup from appearing. This is still being set properly, but the popup is being drawn again for some reason. Example image from a failed run: https://storage.cloud.google.com/chromium-result-details/6df29efbc067c7cd7455ded1d0719a9c7bd04ac2
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d718df0c466074065152ab1ecad8725ee702989b commit d718df0c466074065152ab1ecad8725ee702989b Author: bsheedy <bsheedy@chromium.org> Date: Tue Mar 06 17:57:29 2018 Add VR workaround for 819021 Changes the pixel-checking portion of testRequestPresentEntersVr and testRequestSessionEntersVr to pass if either pure blue or (0, 0, 127) is detected. This is a workaround for https://crbug.com/819021, where the immersive mode popup can cause the screen to be darkened and turn pure blue into (0, 0, 127). Bug: 819021 Change-Id: Id0254358e7c25073d0b7800cecad8ef11f315c58 Reviewed-on: https://chromium-review.googlesource.com/950321 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#541143} [modify] https://crrev.com/d718df0c466074065152ab1ecad8725ee702989b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java
,
Jul 4
,
Jul 5
We can probably remove the workaround and drop test support for K in the near future given the restrictions on dynamic modules.
,
Aug 7
Removing Internals>VR component and assigning to Internals>XR
,
Aug 7
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bpastene@chromium.org
, Mar 6 2018Labels: OS-Android