Tracking changes for in app search integration in Chrome OS launcher. Design doc: go/cros-ipa
Tracking changes for in app search integration in Chrome OS launcher. Android side bug: b/75280456 Design doc: go/cros-ipa
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/139f865383898063512a69e13c7cb65a98f4c7ee commit 139f865383898063512a69e13c7cb65a98f4c7ee Author: Qiang Xu <warx@google.com> Date: Tue Mar 06 22:14:43 2018 app_list: move IconDecodeRequest to separate class changes: Move IconDecodeRequest from inner class of ArcPlayStoreSearchResult to a separate class, since this class is also used for in app search. Bug: 818902 Test: tested that play store search still works Change-Id: Iaa53007b363d82d496115abb5fac64eba5109c1d Reviewed-on: https://chromium-review.googlesource.com/950006 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#541216} [modify] https://crrev.com/139f865383898063512a69e13c7cb65a98f4c7ee/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/139f865383898063512a69e13c7cb65a98f4c7ee/chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.cc [modify] https://crrev.com/139f865383898063512a69e13c7cb65a98f4c7ee/chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.h [add] https://crrev.com/139f865383898063512a69e13c7cb65a98f4c7ee/chrome/browser/ui/app_list/search/arc/icon_decode_request.cc [add] https://crrev.com/139f865383898063512a69e13c7cb65a98f4c7ee/chrome/browser/ui/app_list/search/arc/icon_decode_request.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe7dbc902b675fb2587a00d51bc3c412ded88bad commit fe7dbc902b675fb2587a00d51bc3c412ded88bad Author: Qiang Xu <warx@google.com> Date: Tue Mar 13 19:43:00 2018 arc: introduce personal contacts search to launcher changes: This CL relies on android CL: ag/3691606. This CL introduces the framework of chrome side changes and also did initial UI changes (circular 40px avatar icon) of contacts search result. Bug: 818902 Test: tested on device with android changes patched Change-Id: Id9bb1e2a9c1a1c179f6ceef3abe7249fdad83a7c Reviewed-on: https://chromium-review.googlesource.com/957421 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#542883} [modify] https://crrev.com/fe7dbc902b675fb2587a00d51bc3c412ded88bad/chrome/browser/ui/BUILD.gn [add] https://crrev.com/fe7dbc902b675fb2587a00d51bc3c412ded88bad/chrome/browser/ui/app_list/search/arc/arc_app_data_search_provider.cc [add] https://crrev.com/fe7dbc902b675fb2587a00d51bc3c412ded88bad/chrome/browser/ui/app_list/search/arc/arc_app_data_search_provider.h [add] https://crrev.com/fe7dbc902b675fb2587a00d51bc3c412ded88bad/chrome/browser/ui/app_list/search/arc/arc_app_data_search_result.cc [add] https://crrev.com/fe7dbc902b675fb2587a00d51bc3c412ded88bad/chrome/browser/ui/app_list/search/arc/arc_app_data_search_result.h [modify] https://crrev.com/fe7dbc902b675fb2587a00d51bc3c412ded88bad/chrome/browser/ui/app_list/search/search_controller_factory.cc [modify] https://crrev.com/fe7dbc902b675fb2587a00d51bc3c412ded88bad/components/arc/common/app.mojom [modify] https://crrev.com/fe7dbc902b675fb2587a00d51bc3c412ded88bad/components/arc/test/fake_app_instance.cc [modify] https://crrev.com/fe7dbc902b675fb2587a00d51bc3c412ded88bad/components/arc/test/fake_app_instance.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bbbdca3de4ab56dbec159da486313435e12c158 commit 1bbbdca3de4ab56dbec159da486313435e12c158 Author: Qiang Xu <warx@google.com> Date: Thu Mar 15 22:50:40 2018 arc: add ArcAppDataSearchProviderTest Bug: 818902 Test: added test coverage Change-Id: Ie5c0edf874c50be60b48b37833fcf1e8991e5728 Reviewed-on: https://chromium-review.googlesource.com/963089 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#543529} [add] https://crrev.com/1bbbdca3de4ab56dbec159da486313435e12c158/chrome/browser/ui/app_list/search/arc/arc_app_data_search_provider_unittest.cc [modify] https://crrev.com/1bbbdca3de4ab56dbec159da486313435e12c158/chrome/browser/ui/app_list/search/arc/arc_app_data_search_result.cc [modify] https://crrev.com/1bbbdca3de4ab56dbec159da486313435e12c158/chrome/browser/ui/app_list/search/arc/arc_playstore_search_provider_unittest.cc [modify] https://crrev.com/1bbbdca3de4ab56dbec159da486313435e12c158/chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.cc [modify] https://crrev.com/1bbbdca3de4ab56dbec159da486313435e12c158/chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.h [modify] https://crrev.com/1bbbdca3de4ab56dbec159da486313435e12c158/chrome/browser/ui/app_list/search/arc/icon_decode_request.cc [modify] https://crrev.com/1bbbdca3de4ab56dbec159da486313435e12c158/chrome/browser/ui/app_list/search/arc/icon_decode_request.h [modify] https://crrev.com/1bbbdca3de4ab56dbec159da486313435e12c158/chrome/test/BUILD.gn [modify] https://crrev.com/1bbbdca3de4ab56dbec159da486313435e12c158/components/arc/test/fake_app_instance.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1366ef14237daeb24e21d5c4dc0c0f1d8965c3d commit e1366ef14237daeb24e21d5c4dc0c0f1d8965c3d Author: Qiang Xu <warx@google.com> Date: Thu Mar 22 07:24:19 2018 arc: allow null icon image for AppDataSearch changes: For contacts that don't have profile photo set, the image info passed to chrome is null. This CL handles this case. We should provide appropriate default images for this case on Chrome side. Android side change: ag/3774689. Bug: 818902 Test: manual test Change-Id: I03ebe42d8c8930b25c50a3968a9c7c89477f6a76 Reviewed-on: https://chromium-review.googlesource.com/973552 Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#545000} [modify] https://crrev.com/e1366ef14237daeb24e21d5c4dc0c0f1d8965c3d/chrome/browser/ui/app_list/search/arc/arc_app_data_search_result.cc [modify] https://crrev.com/e1366ef14237daeb24e21d5c4dc0c0f1d8965c3d/chrome/browser/ui/app_list/search/arc/arc_app_data_search_result.h [modify] https://crrev.com/e1366ef14237daeb24e21d5c4dc0c0f1d8965c3d/components/arc/common/app.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2493d2f2b2d5ea0fe2408ead141d8cc5c3e28f9 commit d2493d2f2b2d5ea0fe2408ead141d8cc5c3e28f9 Author: Qiang Xu <warx@google.com> Date: Mon Apr 23 17:46:14 2018 arc: plumb note document text body to launcher changes: - Plumb note document text body, android side change: ag/3916628. Bug: 818902 Test: device test and unit_tests ArcAppDataSearchProviderTest.* Change-Id: I82b8bce0ac3117934a57018a299959698649b72d Reviewed-on: https://chromium-review.googlesource.com/1016062 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#552744} [modify] https://crrev.com/d2493d2f2b2d5ea0fe2408ead141d8cc5c3e28f9/chrome/browser/ui/app_list/search/arc/arc_app_data_search_provider_unittest.cc [modify] https://crrev.com/d2493d2f2b2d5ea0fe2408ead141d8cc5c3e28f9/chrome/browser/ui/app_list/search/arc/arc_app_data_search_result.cc [modify] https://crrev.com/d2493d2f2b2d5ea0fe2408ead141d8cc5c3e28f9/chrome/browser/ui/app_list/search/arc/arc_app_data_search_result.h [modify] https://crrev.com/d2493d2f2b2d5ea0fe2408ead141d8cc5c3e28f9/components/arc/common/app.mojom [modify] https://crrev.com/d2493d2f2b2d5ea0fe2408ead141d8cc5c3e28f9/components/arc/test/fake_app_instance.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa213a012c2ab39991a81962b530894100eadf06 commit aa213a012c2ab39991a81962b530894100eadf06 Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Mon Oct 29 17:54:28 2018 Add flags for in-app data search and Play Store search. ArcAppDataSearchProvider used to be created and called unconditionally which is not optimal. Play Store search is already protected by a (disabled by default) feature. Adding a flag makes it easier to debug and test. Bug: 818902 Test: manual, AboutFlagsHistogramTest Change-Id: Ifb20d90de4e1f977b320fd4f14079570bff367bf Reviewed-on: https://chromium-review.googlesource.com/c/1300293 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#603553} [modify] https://crrev.com/aa213a012c2ab39991a81962b530894100eadf06/ash/public/cpp/app_list/app_list_features.cc [modify] https://crrev.com/aa213a012c2ab39991a81962b530894100eadf06/ash/public/cpp/app_list/app_list_features.h [modify] https://crrev.com/aa213a012c2ab39991a81962b530894100eadf06/chrome/browser/about_flags.cc [modify] https://crrev.com/aa213a012c2ab39991a81962b530894100eadf06/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/aa213a012c2ab39991a81962b530894100eadf06/chrome/browser/flag_descriptions.h [modify] https://crrev.com/aa213a012c2ab39991a81962b530894100eadf06/chrome/browser/ui/app_list/search/search_controller_factory.cc [modify] https://crrev.com/aa213a012c2ab39991a81962b530894100eadf06/tools/metrics/histograms/enums.xml
Comment 1 by bugdroid1@chromium.org
, Mar 6 2018