New issue
Advanced search Search tips

Issue 818899 link

Starred by 3 users
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

"ExtensionApiTest.Debugger" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 6 2018 
"ExtensionApiTest.Debugger" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyJAsSBUZsYWtlIhlFeHRlbnNpb25BcGlUZXN0LkRlYnVnZ2VyDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by jbudorick@chromium.org, Mar 6 2018

Labels: OS-Windows
Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/935961 looks like a likely culprit.

This is flaking at a high rate on win7_chromium_rel_ng; please look at this quickly.

Comment 2 by dgozman@chromium.org, Mar 6 2018 

I have an idea for the fix, but I'm not 100% sure it will help. Let me make a patch.

Comment 4 by jbudorick@chromium.org, Mar 6 2018 

Great, thanks for the quick turnaround!
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/439f03a8f8fda0f96b355b8f7b0bc3bcf4bf73c2

commit 439f03a8f8fda0f96b355b8f7b0bc3bcf4bf73c2
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Mar 06 21:34:18 2018

Fix ExtensionApiTest.Debugger flakiness

... by removing newly created tabs in test cases to not affect
other test cases.

TBR=rdevlin.cronin@chromium.org

Bug:  818899 
Change-Id: I76178410e47153bb660d4dcaeea0e27bf77ffdbb
Reviewed-on: https://chromium-review.googlesource.com/951630
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541197}
[modify] https://crrev.com/439f03a8f8fda0f96b355b8f7b0bc3bcf4bf73c2/chrome/test/data/extensions/api_test/debugger/background.js

Comment 6 by dgozman@chromium.org, Mar 6 2018

Status: Fixed (was: Assigned)
Tentatively marking as fixed, please reopen if persists.

Comment 7 by ynovikov@chromium.org, Mar 6 2018 

Issue 819365 has been merged into this issue.
►

Sign in to add a comment