New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818885 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Flaky tests in Findit

Project Member Reported by robert...@chromium.org, Mar 5 2018

Issue description

The following tests have been reported as flaky:
services.test.swarmbot_util_test.SwarmbotUtilTest.testHaveCommitPositionInLocalGitCache

services.test.build_ahead_test.BuildAheadTest.testPlatformToDimensions


 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d675688f10f9a6d6f089d0202a1ff9d9b9b9e771

commit d675688f10f9a6d6f089d0202a1ff9d9b9b9e771
Author: Roberto Carrillo <robertocn@google.com>
Date: Tue Mar 06 00:12:16 2018

[Findit] Use more specific entity id in flaky test.

This speculative fix is aimed at fix a test that has flaked in the infra
waterfall. The culprit seems to be a new test that uses the same names
for the WfTryBot entities it uses.

R=chanli,wylieb,lijeffrey
BUG=818885

Change-Id: Idb49e8630098fed5a499ccbfe1484aed2fed3467
Reviewed-on: https://chromium-review.googlesource.com/950222
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/d675688f10f9a6d6f089d0202a1ff9d9b9b9e771/appengine/findit/services/test/swarmbot_util_test.py

This revision is also a fix for this:

commit 353125d03dd967c6fbb6e63c4f139849cb6f0eb6

[Findit] Make _PlatformToDimensions return a copy of the list.

This is to avoid flakiness caused by possible race condition, because if
we don't return a copy, the values in the global map may be modified
inadvertently.

R=wylieb

Change-Id: Ic94d99c05f3a52fdba7c1a931a20567beb8bb15b
Reviewed-on: https://chromium-review.googlesource.com/949979
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>


Comment 3 by wylieb@chromium.org, Mar 13 2018

This test is flaky:
test.findit_api_test.FinditApiTest.testAnalysisRequestQueuedAsExpected

Comment 4 by st...@chromium.org, Mar 13 2018

re #3: seems like a different root cause of flakiness. Mind a separate bug with a stacktrace?

Comment 5 by st...@chromium.org, Mar 13 2018

This bug summary seems to need updating as well.

Sign in to add a comment