Context: https://chromium-review.googlesource.com/c/chromium/src/+/943064/3/ui/views/controls/textfield/textfield.cc#1057
That CL is adding logic to views::Textfield to support secure text entry on Mac.
But views::Textfield is a ui::TextInputClient. So is RenderWidgetHostViewAura. But RenderWidgetHostViewMac is *not* a ui::TextInputClient (should it be?)
RenderWidgetHostViewMac uses a `SetTextInputActive(bool active)` member function to control secure text entry and https://crrev.com/c/943064 would add that function to views::Textield as well.
Question for IME folks: should this instead be the responsibility of the InputMethod?
E.g. views::Textfield already calls GetInputMethod()->SetFocusedTextInputClient(this); InputMethodMac could override InputMethodBase::OnDidChangeFocusedClient() and call the appropriate methods to set up secure text entry.
Question for rsesek: would this fit with how secure text entry should work on Mac and Issue 677220 ? (I don't know much about secure text entry..)
I'm not sure whether this should block https://crrev.com/c/943064 but it's certainly going to be something to address when exploring MacAura. That is, stuff being added to views::Textfield in that CL may need replacing when RenderWidgetHostViewAura starts getting used on Mac.
Comment 1 by mblsha.y...@gmail.com
, Mar 6 2018