CrOS: update Harfbuzz to match that on other platforms |
||||||
Issue descriptionI'll use this bug as a on-going tracker to update HarfBuzz on Chrome OS to match that on other platforms. Based on Chrome's branching schedule, I'll update HarfBuzz on CrOS a week before branching to match that of other platforms. The latest is this CL: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/940450 Having a bug is also handy when I need to ask for a merge (I missed 66 branch train).
,
Mar 14 2018
Asking for merge approval to R66. Chrome 66.x branch on other platforms has a version of HarfBuzz that's landed in a CL recorded in comment 1. It'd be better to match other platforms in terms of Harfbuzz version in 66.x branch. This has been baked on canary on CrOS. On other platforms, the same version of Harfbuzz has been tested longer and in 66.x branch (dev channel).
,
Mar 14 2018
Just for the record, FreeType version is identical between Chrome OS and other platforms. FreeType update to 2.9.0 + 20 CLs had been landed right before R66 branch was cut. ( https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/939719 )
,
Mar 14 2018
Marking as fixed in ToT.
,
Mar 15 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/942ba032c675eb0d742604b624ba9bece05bd98c commit 942ba032c675eb0d742604b624ba9bece05bd98c Author: Jungshik Shin <jshin@chromium.org> Date: Thu Mar 15 19:44:13 2018 [R66 branch] Update Harfbuzz to 1.7.5 and up to 0bff6991 This is to match Harfbuzz on other platforms. harfbuzz-1.7.5.324.tar.bz2 was obtained as following from the harfbuzz git tree : 1. git checkout 0bff6991 2. sh autogen.sh 3. ./configure 4. make distcheck 5. rename the top directory to harfbuzz-1.7.5.324 6. make a tar ball. Making a giant patch against harfbuzz-1.7.5.tar.bz to go up to 0bff6991 (324 CLs) does not work because applying the patch changes Makefile.am (multiple of them) and configure.ac. With the time stamp of those files updated by the patch application, `make' looks for the same version of aclocal and autoconf as used in 'make distcheck' step above eventually leading to a build failure. The simplest way is to upload the tar ball made above to the CrOS common storage and use it directly without a patch. BUG= 818862 TEST=emerge-${BOARD} harfbuzz TEST=cros tryjob -g 940450 chromiumos-sdk amd64-generic-full daisy-full Change-Id: I8ba14b4b8349dfbcd3a487e21b7af96de59d1b6a Previous-Reviewed-on: https://chromium-review.googlesource.com/940450 (cherry picked from commit 024270ae547a5573cd3730da11850c8ce23063ef) Reviewed-on: https://chromium-review.googlesource.com/962987 Tested-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> [rename] https://crrev.com/942ba032c675eb0d742604b624ba9bece05bd98c/media-libs/harfbuzz/harfbuzz-1.7.5.324.ebuild [add] https://crrev.com/942ba032c675eb0d742604b624ba9bece05bd98c/media-libs/harfbuzz/harfbuzz-1.7.5.324-r1.ebuild [modify] https://crrev.com/942ba032c675eb0d742604b624ba9bece05bd98c/media-libs/harfbuzz/Manifest [delete] https://crrev.com/5272fc9d0fcbeda7944c66c772247ab7827e8679/media-libs/harfbuzz/harfbuzz-1.6.3-r1.ebuild
,
Mar 19 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 21 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 6 2018