New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 818856 link

Starred by 1 user
Status: Fixed
Owner:
█ mharanc...@opera.com
Last visit 15 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Building blink_tests locally fails due to AccessibleObjectFromWindow

Project Member Reported by cnardi@chromium.org, Mar 5 2018 
When building blink_tests locally, the build fails at the end during linking with:

FAILED: blink_heap_unittests.exe blink_heap_unittests.exe.pdb
F:/chromium/windows/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False link.exe /nologo /OUT:./blink_heap_unittests.exe /PDB:./blink_heap_unittests.exe.pdb @./blink_heap_unittests.exe.rsp
test_support.lib(test_support_jumbo_1.obj) : error LNK2019: unresolved external symbol AccessibleObjectFromWindow referenced in function "private: long __cdecl content::AccessibilityEventRecorderWin::AccessibleObjectFromWindowWrapper(struct HWND__ *,unsigned long,struct _GUID const &,void * *)" (?AccessibleObjectFromWindowWrapper@AccessibilityEventRecorderWin@content@@AEAAJPEAUHWND__@@KAEBU_GUID@@PEAPEAX@Z)

This build was working only a few weeks ago prior to syncing the latest sources. It is a jumbo build, release with clang.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/421438b4822ea43daa2ea3058f3407da88c223fd

commit 421438b4822ea43daa2ea3058f3407da88c223fd
Author: Marek Haranczyk <mharanczyk@opera.com>
Date: Wed Mar 07 09:48:30 2018

Fix linking problems caused by //content/test:test_support target on win.

//content/browser/accessibility/accessibility_event_recorder_win.cc in
this target is missing required lib on win in component builds.
In non-component oleacc.lib is added indirectly through
//content/browser:for_content_tests -> //content/browser dependency chain.

The change fixes missing AccessibleObjectFromWindow symbol linking error
for content_unittests and webkit_unit_tests in component build.

BUG:  818856 
Change-Id: I1253bbbff5ca346f2fe4f81d0fc71834bb158222
Reviewed-on: https://chromium-review.googlesource.com/951383
Commit-Queue: Marek Haranczyk <mharanczyk@opera.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541396}
[modify] https://crrev.com/421438b4822ea43daa2ea3058f3407da88c223fd/content/test/BUILD.gn

Comment 2 by mharanc...@opera.com, Mar 7 2018

Owner: mharanc...@opera.com
Status: Fixed (was: Untriaged)
►

Sign in to add a comment