New issue
Advanced search Search tips

Issue 818854 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

my_reviews.py not working with Gerrit.

Project Member Reported by dpa...@chromium.org, Mar 5 2018

Issue description

The following command returns no results

my_reviews.py --begin="2018-01-01" --end="2018-03-05"

even though there are plenty of reviews in that range. Looking at the source code, it seems that the tool only works with the old Rietveld 
 code review tool.
 
Status: WontFix (was: Untriaged)
my_activity.py works for Gerrit.
Can you elaborate a bit on how to make my_activity.py output similar information with my_reviews.py?

my_reviews.py outputs median and average time to respond to code reviews. Pasting output below:

dpapad@chromium.org reviewed 169 issues out of 187 (90.4%). 0 were self-review.
 1.8 review request/day during 102 days   ( 1.7 r/d done).
  11 were drive-bys                       (  6.5% of reviews done).
   1 were requested over IM or irc        (  0.6% of reviews done).
 152 issues LGTM'd                        ( 89.9% of reviews done), gave multiple LGTMs on 11 issues.
Average latency from request to first comment is 1d12h37m.
Median latency from request to first comment is 02h16m.

When I try my_activity.py, I only get a list of CLs, similar to what I can already see in the dashboard (https://chromium-review.googlesource.com/dashboard/self).

Are you suggesting that my_reviews.py and my_activity.py are equivalent tools? Should I be passing any flags to my_activity.py to get similar output? IIUC, these are two very different tools, the former works with rietveld, the latter with gerrit.

Sign in to add a comment