https://chromium-review.googlesource.com/c/chromium/src/+/949963

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6783e46fa01a4da9c9b764d1858eb3c3f9b03f9e

commit 6783e46fa01a4da9c9b764d1858eb3c3f9b03f9e
Author: Chris Palmer <palmer@chromium.org>
Date: Mon Mar 05 23:34:29 2018

Correct off-by-one in `Tokenizer::CanIncrement`.

It would return true even if you were actually at the end of the input.

Bug:  818844 
Change-Id: I0ba5be52b568e39a087efc1e8114138ac4c18799
Reviewed-on: https://chromium-review.googlesource.com/949963
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540982}
[modify] https://crrev.com/6783e46fa01a4da9c9b764d1858eb3c3f9b03f9e/tools/gn/tokenizer.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8bccdf109b1dcad454f4e26e868dc3d3af099f0

commit c8bccdf109b1dcad454f4e26e868dc3d3af099f0
Author: Chris Palmer <palmer@chromium.org>
Date: Tue Mar 06 01:13:25 2018

Add range checks for `StringPiece`.

Range check `operator[]`, `front`, `back`, and  `remove_{pre,suf}fix`.

Bug: 817982, 818376 , 818844 
Change-Id: I3a0b560af273c9b04237a18a1bc0b56283d3d824
Reviewed-on: https://chromium-review.googlesource.com/945049
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541012}
[modify] https://crrev.com/c8bccdf109b1dcad454f4e26e868dc3d3af099f0/base/strings/string_piece.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b0c7b406613114aa86bbe9040756e99fd913518

commit 2b0c7b406613114aa86bbe9040756e99fd913518
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Tue Mar 06 09:44:42 2018

Revert "Add range checks for `StringPiece`."

This reverts commit c8bccdf109b1dcad454f4e26e868dc3d3af099f0.

Reason for revert: This change has r540894 as dependency. However, r540894 was reverted in r541006, just before this patch landed. Since this currently causes failures on Mac due to crashpad errors, I am reverting this change for now.

Original change's description:
> Add range checks for `StringPiece`.
> 
> Range check `operator[]`, `front`, `back`, and  `remove_{pre,suf}fix`.
> 
> Bug: 817982, 818376 , 818844 
> Change-Id: I3a0b560af273c9b04237a18a1bc0b56283d3d824
> Reviewed-on: https://chromium-review.googlesource.com/945049
> Commit-Queue: Chris Palmer <palmer@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541012}

TBR=palmer@chromium.org,dcheng@chromium.org,mark@chromium.org

Change-Id: I7d5c2ca050869aff8dca4ba6b724761172aa1d83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 817982,  818376 ,  818844 
Reviewed-on: https://chromium-review.googlesource.com/950822
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541060}
[modify] https://crrev.com/2b0c7b406613114aa86bbe9040756e99fd913518/base/strings/string_piece.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5a6dfada32caaccc93e4f3ca4cb0bd0f6cdd019

commit e5a6dfada32caaccc93e4f3ca4cb0bd0f6cdd019
Author: Chris Palmer <palmer@chromium.org>
Date: Tue Mar 06 21:40:08 2018

Reland "Add range checks for `StringPiece`."

This reverts commit 2b0c7b406613114aa86bbe9040756e99fd913518.

Reason for revert: https://chromium-review.googlesource.com/950466 re-fixed the crashpad bug, so we should be good to land this again.

Original change's description:
> Revert "Add range checks for `StringPiece`."
> 
> This reverts commit c8bccdf109b1dcad454f4e26e868dc3d3af099f0.
> 
> Reason for revert: This change has r540894 as dependency. However, r540894 was reverted in r541006, just before this patch landed. Since this currently causes failures on Mac due to crashpad errors, I am reverting this change for now.
> 
> Original change's description:
> > Add range checks for `StringPiece`.
> > 
> > Range check `operator[]`, `front`, `back`, and  `remove_{pre,suf}fix`.
> > 
> > Bug: 817982, 818376 , 818844 
> > Change-Id: I3a0b560af273c9b04237a18a1bc0b56283d3d824
> > Reviewed-on: https://chromium-review.googlesource.com/945049
> > Commit-Queue: Chris Palmer <palmer@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Mark Mentovai <mark@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#541012}
> 
> TBR=palmer@chromium.org,dcheng@chromium.org,mark@chromium.org
> 
> Change-Id: I7d5c2ca050869aff8dca4ba6b724761172aa1d83
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 817982,  818376 ,  818844 
> Reviewed-on: https://chromium-review.googlesource.com/950822
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541060}

TBR=palmer@chromium.org,dcheng@chromium.org,mark@chromium.org,jdoerrie@chromium.org

Change-Id: I50637027781401fc96b75bb749c5baa80dcc14a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 817982,  818376 ,  818844 
Reviewed-on: https://chromium-review.googlesource.com/951868
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541201}
[modify] https://crrev.com/e5a6dfada32caaccc93e4f3ca4cb0bd0f6cdd019/base/strings/string_piece.h

This breaks GCC build, at least on arm. You are adding CHECK() inside a constexpr, and CHECK() will eventually include an asm call. That is not allowed in gcc (and is not allowed in C++14 as can be seen in dcl.constexpr/4).

This is one example of the build error we are getting after landing this:

./../../../../../../../../upstream-chromium/src/base/strings/string_piece.h: In member function 'constexpr base::BasicStringPiece<STRING_TYPE>::value_type base::BasicStringPiece<STRING_TYPE>::operator[](base::BasicStringPiece<STRING_TYPE>::size_type) const':
../../../../../../../../../upstream-chromium/src/base/logging.h:542:3: error: 'asm' in 'constexpr' function
   asm volatile("bkpt #0; udf %0;" ::"i"(__COUNTER__ % 256))
   ^
../../../../../../../../../upstream-chromium/src/base/logging.h:557:5: note: in expansion of macro 'TRAP_SEQUENCE'
     TRAP_SEQUENCE();         \
     ^~~~~~~~~~~~~
../../../../../../../../../upstream-chromium/src/base/logging.h:605:28: note: in expansion of macro 'IMMEDIATE_CRASH'
   UNLIKELY(!(condition)) ? IMMEDIATE_CRASH() : EAT_STREAM_PARAMETERS
                            ^~~~~~~~~~~~~~~
../../../../../../../../../upstream-chromium/src/base/strings/string_piece.h:223:5: note: in expansion of macro 'CHECK'
     CHECK(i < length_);
     ^~~~~