WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting_WebXr is flaky |
|||||||
Issue descriptionAccording to https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=chrome_public_test_vr_apk%20(with%20patch)&tests=org.chromium.chrome.browser.vr_shell.WebVrTransitionTest%23testWindowRafStopsFiringWhilePresenting_WebXr, testWindowRafStopsFiringWhilePresenting_WebXr is a bit flaky. Not enough to cause any actual failures, but one iteration seems to fail every several runs. The reported cause is window.rAF firing while we're presenting. Since this doesn't happen most of the time, we're successfully stopping it in most cases, but it seems like it's still possible for window.rAF to fire for a few moments after we enter VR. It's worth noting that the WebVR version of this test is completely stable, so this is a WebXR-specific thing.
,
Mar 7 2018
Looks like it is actually possible for this to happen in the WebVR versions, it's just far, far less common.
,
Mar 21 2018
,
Mar 21 2018
Increasing priority since apparently this is causing some flakes on the CQ.
,
Mar 22 2018
Detected 3 new flakes for test/step "org.chromium.chrome.browser.vr_shell.WebVrTransitionTest#testWindowRafStopsFiringWhilePresenting_WebXr__CustomTabActivity". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyhAELEgVGbGFrZSJ5b3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLnZyX3NoZWxsLldlYlZyVHJhbnNpdGlvblRlc3QjdGVzdFdpbmRvd1JhZlN0b3BzRmlyaW5nV2hpbGVQcmVzZW50aW5nX1dlYlhyX19DdXN0b21UYWJBY3Rpdml0eQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Mar 22 2018
Issue 824835 has been merged into this issue.
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8444f185486401fb99f69b68f0d00762f6fb664b commit 8444f185486401fb99f69b68f0d00762f6fb664b Author: bsheedy <bsheedy@chromium.org> Date: Fri Mar 23 00:09:28 2018 Fix VR/XR window.rAF test flakiness Fixes the flakiness seen in testWindowRafStopsFiringWhilePresenting* tests. The tests had erroneously assumed that normal VSyncs were synchronously stopped, so window.rAF should never fire once we're in VR. It turns out that this is done asynchronously, so we wait until it's been set Java-side, and allow up to 2 additional frames to call window.rAF due to additional native asynchronous code that's much more difficult to wait on to complete. Bug: 818841 Change-Id: Ic7b23681ea9f3942086bbca1843959562f58c039 Reviewed-on: https://chromium-review.googlesource.com/976695 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#545297} [modify] https://crrev.com/8444f185486401fb99f69b68f0d00762f6fb664b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/8444f185486401fb99f69b68f0d00762f6fb664b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/8444f185486401fb99f69b68f0d00762f6fb664b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/TestVrShellDelegate.java [modify] https://crrev.com/8444f185486401fb99f69b68f0d00762f6fb664b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java [modify] https://crrev.com/8444f185486401fb99f69b68f0d00762f6fb664b/chrome/test/data/vr/e2e_test_files/html/test_window_raf_stops_firing_while_presenting.html [modify] https://crrev.com/8444f185486401fb99f69b68f0d00762f6fb664b/chrome/test/data/vr/e2e_test_files/html/webxr_test_window_raf_stops_firing_during_exclusive_session.html
,
Mar 23 2018
Looks like the fix worked. I'm still seeing the rare case of fail pass, but it's not causing any actual failures.
,
Mar 23 2018
,
Jul 4
,
Aug 29
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bsheedy@chromium.org
, Mar 5 2018Status: Assigned (was: Available)