Issue metadata
Sign in to add a comment
|
[Select-to-Speak] Add user-facing setting to control whether speech continues after nodes go away |
||||||||||||||||||||||||
Issue descriptionThis may be confusing for novice users because speech continues while the focus rings are totally gone. But for advanced users, they may wish to close windows and navigate around while speech is in progress. Chatted with dmazzoni@ about lpalmaro@'s use-case and figured this was a good thing to try behind a flag.
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80d1057bdfc7b78cc1344c71b26b27835f21aca6 commit 80d1057bdfc7b78cc1344c71b26b27835f21aca6 Author: Katie D <katie@chromium.org> Date: Wed Mar 07 22:41:05 2018 Adds user setting to allow speech to continue after text goes away. If the Accessibility node becomes undefined during reading, the default behavior is to stop reading immediately. This allows STS to continue reading hen nodes are undefined. Advanced users may want more control over text, while novice users may be surprised when text continues after windows are closed (and there's no visual indicator that speech is still in prgoress). An open question is whether this should also apply to nodes that disappear from the screen after their window is closed or minimized, or if they are scrolled off screen. Right now, that behavior is read and is unchanged by this patch. Adds this behind the --enable-experimental-accessibility-features flag in Chrome OS. Bug: 818835 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib063d6ac5071f35a5d4e0a90cd472bb0ffc165f9 Reviewed-on: https://chromium-review.googlesource.com/949776 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#541617} [modify] https://crrev.com/80d1057bdfc7b78cc1344c71b26b27835f21aca6/chrome/browser/resources/chromeos/select_to_speak/compiled_resources2.gyp [modify] https://crrev.com/80d1057bdfc7b78cc1344c71b26b27835f21aca6/chrome/browser/resources/chromeos/select_to_speak/options.html [modify] https://crrev.com/80d1057bdfc7b78cc1344c71b26b27835f21aca6/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js [modify] https://crrev.com/80d1057bdfc7b78cc1344c71b26b27835f21aca6/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_options.js [modify] https://crrev.com/80d1057bdfc7b78cc1344c71b26b27835f21aca6/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings.grd
,
Mar 8 2018
Issue 819907 has been merged into this issue.
,
Mar 16 2018
Sounds like UI review doesn't want this setting, so I'll remove it again.
,
Mar 19 2018
,
Mar 19 2018
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e54ceb298c5dd2a20eb2f0215d25db917465dc87 commit e54ceb298c5dd2a20eb2f0215d25db917465dc87 Author: Katie D <katie@chromium.org> Date: Mon Mar 19 19:07:37 2018 Always continue speaking after text goes away in STS. This mostly reverts the commit, "Adds user setting to allow speech to continue after text goes away." (commit 80d1057bdfc7b78cc1344c71b26b27835f21aca6) However, the private variable readAfterClose_ was kept in order to by default keep reading, but make it easy to change this functionality later. After UI review, it was determined that the setting is unnecessary. We will just always speak after text goes away. This may be confusing for novice users but should get better once we have the on-screen UI. Bug: 818835 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I04a36b717251ef88283570a690e42366c035dded Reviewed-on: https://chromium-review.googlesource.com/967241 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#544094} [modify] https://crrev.com/e54ceb298c5dd2a20eb2f0215d25db917465dc87/chrome/browser/resources/chromeos/select_to_speak/compiled_resources2.gyp [modify] https://crrev.com/e54ceb298c5dd2a20eb2f0215d25db917465dc87/chrome/browser/resources/chromeos/select_to_speak/options.html [modify] https://crrev.com/e54ceb298c5dd2a20eb2f0215d25db917465dc87/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js [modify] https://crrev.com/e54ceb298c5dd2a20eb2f0215d25db917465dc87/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_options.js [modify] https://crrev.com/e54ceb298c5dd2a20eb2f0215d25db917465dc87/chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings.grd
,
Mar 19 2018
Current and UI approved behavior: Always keep reading after nodes go away. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by rameshku...@gmail.com
, Mar 6 2018