New issue
Advanced search Search tips

Issue 818817 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Unexpected blue text on top of the history page

Project Member Reported by asimjour@chromium.org, Mar 5 2018

Issue description

History page has a rectangle on top with incorrect texture.
 
Screenshot_20180305-154609.png
883 KB View Download
Cc: mthiesse@chromium.org
Labels: -Pri-2 -Proj-VR-Shell M-67 Pri-1
Status: Available (was: Untriaged)

Comment 3 by tiborg@chromium.org, Mar 14 2018

Labels: Hotlist-VRB-MVP

Comment 4 by tiborg@chromium.org, Mar 14 2018

Owner: tiborg@chromium.org
Status: Started (was: Available)
Cc: dougman@chromium.org
 Issue 821854  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42c00f868654f9d32cf9cab5d23a360847d682ab

commit 42c00f868654f9d32cf9cab5d23a360847d682ab
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Thu Apr 05 21:53:33 2018

[vr] Remove BasicNativePages's top offset when browser controls hidden

While in VR we hide the browser controls. This leads to an offset at the
top of the history page. And this results in distorted graphics showing
up due to an ininitialized buffer. To fix that move the UI up while in
VR.

Bug:  818817 
Change-Id: I2e6113f410f644447a741ae7d339d2c8454db2f5
Reviewed-on: https://chromium-review.googlesource.com/963502
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548573}
[modify] https://crrev.com/42c00f868654f9d32cf9cab5d23a360847d682ab/chrome/android/java/src/org/chromium/chrome/browser/BasicNativePage.java
[modify] https://crrev.com/42c00f868654f9d32cf9cab5d23a360847d682ab/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
[modify] https://crrev.com/42c00f868654f9d32cf9cab5d23a360847d682ab/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/42c00f868654f9d32cf9cab5d23a360847d682ab/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java

Status: Fixed (was: Started)
Labels: Test-Complete
Status: Verified (was: Fixed)
Fix verified in build 67.0.3396.29 beta.  Looks good.

Sign in to add a comment