New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818798 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 853312
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 808487
issue 834330



Sign in to add a comment

Remove duplicate DEPS-parsing logic from deps2submodules

Project Member Reported by aga...@chromium.org, Mar 5 2018

Issue description

We maintain repos which are identical to their upstreams, with the exception that they include git submodules instead of DEPS files. These repos are maintained by deps2submodules (https://ci.chromium.org/buildbot/chromium.infra.codesearch/codesearch-submodules-chromium/), which means that DEPS-parsing logic is duplicated there.

We should either:
a) give gclient the ability to output .gitmodules files so deps2submodules can lose that logic; or
b) give deps2submodules the ability to import and use gclient_eval.py.
 
Issue 808599 has been merged into this issue.
Blocking: 808487
Owner: flyboy@chromium.org
Status: Assigned (was: Untriaged)
I started https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/952211 (a), but we're going to take approach (b) instead: https://chromium-review.googlesource.com/c/infra/infra/+/954009 shows how to make an infra.service.foo like gsubtreed which can import gclient_eval, so that's going to be our path forward.

Alan is working on a short doc to clarify thoughts.

Comment 4 by flyboy@chromium.org, Apr 18 2018

Blocking: 834330

Comment 5 by flyboy@chromium.org, Jun 15 2018

Mergedinto: 853312
Status: Duplicate (was: Assigned)

Sign in to add a comment