New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 818776
issue 818771
issue 818773



Sign in to add a comment
link

Issue 818769: Improve skia fuzzing

Reported by infe...@chromium.org, Mar 5 2018 Project Member

Issue description

See title.
 

Comment 1 by infe...@chromium.org, Mar 5 2018

Blockedon: 818771

Comment 2 by infe...@chromium.org, Mar 5 2018

Blockedon: 818773

Comment 3 by infe...@chromium.org, Mar 5 2018

Blockedon: 818776

Comment 4 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ec1c620316685cb0e9f41dbbef805e74c61142a8

commit ec1c620316685cb0e9f41dbbef805e74c61142a8
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Dec 14 17:11:56 2018

Avoid system fonts when fuzzing

This should make reproducing certain fuzzes easier between oss-fuzz
and a typical dev's desktop.

This was the most straight-forward way I could think of to
accomplish this.  An ideal solution would "compile" a set of
fonts that was not the test set and embed it, but I lack the
domain knowledge to craft such a set.

If this method works ok, we can explore making the font set
more robust and varied.

Bug: 818769
Change-Id: I03eb2bc316caf7aec3ffa88e59ff29d76c8557ec
Reviewed-on: https://skia-review.googlesource.com/c/177800
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

[modify] https://crrev.com/ec1c620316685cb0e9f41dbbef805e74c61142a8/modules/skottie/BUILD.gn
[modify] https://crrev.com/ec1c620316685cb0e9f41dbbef805e74c61142a8/fuzz/oss_fuzz/FuzzRasterN32Canvas.cpp
[modify] https://crrev.com/ec1c620316685cb0e9f41dbbef805e74c61142a8/modules/skottie/fuzz/FuzzSkottieJSON.cpp
[modify] https://crrev.com/ec1c620316685cb0e9f41dbbef805e74c61142a8/fuzz/oss_fuzz/FuzzNullCanvas.cpp
[modify] https://crrev.com/ec1c620316685cb0e9f41dbbef805e74c61142a8/BUILD.gn
[modify] https://crrev.com/ec1c620316685cb0e9f41dbbef805e74c61142a8/fuzz/oss_fuzz/FuzzImageFilterDeserialize.cpp
[modify] https://crrev.com/ec1c620316685cb0e9f41dbbef805e74c61142a8/fuzz/oss_fuzz/FuzzTextBlobDeserialize.cpp
[modify] https://crrev.com/ec1c620316685cb0e9f41dbbef805e74c61142a8/fuzz/oss_fuzz/FuzzMockGPUCanvas.cpp

Comment 5 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df641df1ddbd97c134c3249d20cec5534b31c08e

commit df641df1ddbd97c134c3249d20cec5534b31c08e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Dec 15 03:23:05 2018

Roll src/third_party/skia af67819ee1d9..a1bded9a4f28 (9 commits)

https://skia.googlesource.com/skia.git/+log/af67819ee1d9..a1bded9a4f28


git log af67819ee1d9..a1bded9a4f28 --date=short --no-merges --format='%ad %ae %s'
2018-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 dfaccbc08abb..a7af56be7a6c (3 commits)
2018-12-14 bsalomon@google.com Fix stroked round capped circular arc batched with filled circle.
2018-12-14 bungeman@google.com CG smoothing implies gamma blit.
2018-12-14 kjlubick@google.com [canvaskit] Canvas API for loading fonts
2018-12-14 kjlubick@google.com [canvaskit] Expose setVolatile (especially for animations)
2018-12-14 benjaminwagner@google.com Add another NVIDIA LSAN suppression.
2018-12-14 bsalomon@google.com Reduce the number of backend->pixelconfig GrCaps virtuals.
2018-12-14 kjlubick@google.com Avoid system fonts when fuzzing
2018-12-14 caryclark@skia.org protect against fuzz generated fLastMoveToIndex


Created with:
  gclient setdep -r src/third_party/skia@a1bded9a4f28

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:b/119394958,chromium:901611,chromium:818769
TBR=ethannicholas@chromium.org

Change-Id: I47033164a4df7fc2b617c556f07232bc1ee033b0
Reviewed-on: https://chromium-review.googlesource.com/c/1378836
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#616939}
[modify] https://crrev.com/df641df1ddbd97c134c3249d20cec5534b31c08e/DEPS

Sign in to add a comment