DevTools: it is not possible to remove breakpoint from not mapped script |
|||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open web site, add workspace (2) Set breakpoint (3) Open another web site, open script with breakpoints (should be not mapped to any network resource on current web site) (4) Remove breakpoint (5) Reload DevTools What is the expected result? No breakpoint What happens instead? Breakpoint is ressurected
,
Mar 6 2018
,
Mar 6 2018
Please add affected OSs.
,
Mar 6 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 7 2018
All OS affected since all of them shared the same DevTools frontend code.
,
Mar 7 2018
Tested the issue using #67.0.3364.0 on Mac 10.13.3 as per the steps mentioned in original comment. @kozy: Could you please find the attached video and confirm about the Fix. Thanks!!
,
Mar 7 2018
kozy@, ptal comment #6 and also let us know how is the revert listed at #1 looking in canary? If all looks good, I can approve merge to M66. Thank you.
,
Mar 12 2018
kozy@, could you ptal comment #7 pls and update the bug?
,
Mar 12 2018
,
Mar 13 2018
Please merge this change as soon as possible
,
Mar 16 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 20 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2018
kozy@, reminder to please merge to M66 branch 3359 asap.
,
Mar 29 2018
Please merge this today!
,
Mar 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ca6bc31cfcdb34f2bb48f3abb2866eced13a8f0 commit 7ca6bc31cfcdb34f2bb48f3abb2866eced13a8f0 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Mar 29 18:22:55 2018 Revert "[DevTools] copyBreakpoints should not remove breakpoint from storage" Original CL makes breakpoints not removable from not mapped FS UISourceCodes. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/902327 R=dgozman@chromium.org TBR=kozyatinskiy@chromium.org (cherry picked from commit 4c6e7e4b353385a58513fca720666c75269f8900) Bug: chromium:818763 Change-Id: I63be06287545271679b6f8248585ddae422631a9 Reviewed-on: https://chromium-review.googlesource.com/949454 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540935} Reviewed-on: https://chromium-review.googlesource.com/985910 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#498} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/7ca6bc31cfcdb34f2bb48f3abb2866eced13a8f0/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js
,
Mar 30 2018
,
Apr 4 2018
Tested the issue on latest chrome Beta# 66.0.3359.81 using Mac 10.12.6 with steps mentioned below: 1) Launched chrome reported version, opened one website and added workspace to it in Devtools > Sources > Filesystem and set the breakpoint to it 2) Opened another website and opened script with breakpoint 3) Removed the breakpoint and reloaded the page, breakpoint didn't appeared again @kozy: Please find the attached screen cast for your reference and help in verifying the fix. Thanks! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 5 2018