New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818763 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools: it is not possible to remove breakpoint from not mapped script

Project Member Reported by kozy@chromium.org, Mar 5 2018

Issue description

What steps will reproduce the problem?
(1) Open web site, add workspace
(2) Set breakpoint
(3) Open another web site, open script with breakpoints (should be not mapped to any network resource on current web site)
(4) Remove breakpoint
(5) Reload DevTools

What is the expected result?
No breakpoint

What happens instead?
Breakpoint is ressurected

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c6e7e4b353385a58513fca720666c75269f8900

commit 4c6e7e4b353385a58513fca720666c75269f8900
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Mar 05 21:10:42 2018

Revert "[DevTools] copyBreakpoints should not remove breakpoint from storage"

Original CL makes breakpoints not removable from not mapped FS UISourceCodes.
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/902327

R=dgozman@chromium.org

Bug:  chromium:818763 
Change-Id: I63be06287545271679b6f8248585ddae422631a9
Reviewed-on: https://chromium-review.googlesource.com/949454
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540935}
[modify] https://crrev.com/4c6e7e4b353385a58513fca720666c75269f8900/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js

Comment 2 by kozy@chromium.org, Mar 6 2018

Labels: Merge-Request-66
Please add affected OSs.
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 6 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by kozy@chromium.org, Mar 7 2018

Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Mac OS-Windows
All OS affected since all of them shared the same DevTools frontend code.
Labels: Needs-Feedback
Tested the issue using #67.0.3364.0 on Mac 10.13.3 as per the steps mentioned in original comment.

@kozy: Could you please find the attached video and confirm about the Fix.

Thanks!!
818763.mp4
10.1 MB View Download
kozy@, ptal comment #6 and also let us know how is the revert listed at #1 looking in canary? If all looks good, I can approve merge to M66. Thank you.

Comment 8 by gov...@chromium.org, Mar 12 2018

kozy@, could you ptal comment #7 pls and update the bug?

Comment 9 by cmasso@google.com, Mar 12 2018

Labels: -Hotlist-Merge-Review -Merge-Review-66 Merge-Approved-66

Comment 10 by cmasso@google.com, Mar 13 2018

Please merge this change as soon as possible
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 16 2018

Cc: cmasso@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 20 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
kozy@, reminder to please merge to M66 branch 3359 asap.

Comment 14 by cmasso@google.com, Mar 29 2018

Please merge this today!
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 29 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ca6bc31cfcdb34f2bb48f3abb2866eced13a8f0

commit 7ca6bc31cfcdb34f2bb48f3abb2866eced13a8f0
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Mar 29 18:22:55 2018

Revert "[DevTools] copyBreakpoints should not remove breakpoint from storage"

Original CL makes breakpoints not removable from not mapped FS UISourceCodes.
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/902327

R=dgozman@chromium.org
TBR=kozyatinskiy@chromium.org

(cherry picked from commit 4c6e7e4b353385a58513fca720666c75269f8900)

Bug:  chromium:818763 
Change-Id: I63be06287545271679b6f8248585ddae422631a9
Reviewed-on: https://chromium-review.googlesource.com/949454
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540935}
Reviewed-on: https://chromium-review.googlesource.com/985910
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#498}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/7ca6bc31cfcdb34f2bb48f3abb2866eced13a8f0/third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js

Comment 16 by kozy@chromium.org, Mar 30 2018

Status: Fixed (was: Assigned)
Tested the issue on latest chrome Beta# 66.0.3359.81 using Mac 10.12.6 with steps mentioned below:
1) Launched chrome reported version, opened one website and added workspace to it in Devtools > Sources > Filesystem and set the breakpoint to it
2) Opened another website and opened script with breakpoint
3) Removed the breakpoint and reloaded the page, breakpoint didn't appeared again

@kozy: Please find the attached screen cast for your reference and help in verifying the fix.

Thanks!

818763.mp4
5.8 MB View Download

Sign in to add a comment