New issue
Advanced search Search tips

Issue 818750 link

Starred by 2 users
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

VR: Remove GVR orientation workaround and resume DisplaySynchronizer manually

Project Member Reported by mthiesse@chromium.org, Mar 5 2018 
GVR is considering a hotfix for b/74078759, which would interact poorly with my workaround in  issue 817889 . We should instead resume the DisplaySynchronizer manually to have GVR listen for display changes.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd76e25bd1b55c41eb2024d20a4b7f9ea03203ea

commit cd76e25bd1b55c41eb2024d20a4b7f9ea03203ea
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Tue Mar 06 18:30:53 2018

VR: Pause/Resume DisplaySynchronizer to handle device orientation

Prior to GVR 1.13, the DisplaySynchronizer would start resumed, but with
1.13 this behaviour was changed. This lead to the DisplaySynchronizer
not picking up orientation changes and WebVR being rotated in landscape.

Bug:  817889 ,  818750 
Change-Id: I77202d2d0d7b6feb340483e87491e2b5c1009042
Reviewed-on: https://chromium-review.googlesource.com/951642
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541154}
[modify] https://crrev.com/cd76e25bd1b55c41eb2024d20a4b7f9ea03203ea/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/cd76e25bd1b55c41eb2024d20a4b7f9ea03203ea/device/vr/android/gvr/gvr_delegate.cc
[modify] https://crrev.com/cd76e25bd1b55c41eb2024d20a4b7f9ea03203ea/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/cd76e25bd1b55c41eb2024d20a4b7f9ea03203ea/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/cd76e25bd1b55c41eb2024d20a4b7f9ea03203ea/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/cd76e25bd1b55c41eb2024d20a4b7f9ea03203ea/device/vr/android/java/src/org/chromium/device/vr/NonPresentingGvrContext.java
[modify] https://crrev.com/cd76e25bd1b55c41eb2024d20a4b7f9ea03203ea/third_party/gvr-android-sdk/display_synchronizer_jni.h
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 13 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f7cf4e0b43486fd153cc2922332f2eb7e89d111

commit 7f7cf4e0b43486fd153cc2922332f2eb7e89d111
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Tue Mar 13 14:42:06 2018

VR: Pause/Resume DisplaySynchronizer to handle device orientation

Prior to GVR 1.13, the DisplaySynchronizer would start resumed, but with
1.13 this behaviour was changed. This lead to the DisplaySynchronizer
not picking up orientation changes and WebVR being rotated in landscape.

TBR=mthiesse@chromium.org

(cherry picked from commit cd76e25bd1b55c41eb2024d20a4b7f9ea03203ea)

Bug:  817889 ,  818750 
Change-Id: I77202d2d0d7b6feb340483e87491e2b5c1009042
Reviewed-on: https://chromium-review.googlesource.com/951642
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541154}
Reviewed-on: https://chromium-review.googlesource.com/960584
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#197}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/7f7cf4e0b43486fd153cc2922332f2eb7e89d111/chrome/browser/android/vr/vr_shell_gl.cc
[modify] https://crrev.com/7f7cf4e0b43486fd153cc2922332f2eb7e89d111/device/vr/android/gvr/gvr_delegate.cc
[modify] https://crrev.com/7f7cf4e0b43486fd153cc2922332f2eb7e89d111/device/vr/android/gvr/gvr_delegate.h
[modify] https://crrev.com/7f7cf4e0b43486fd153cc2922332f2eb7e89d111/device/vr/android/gvr/gvr_device.cc
[modify] https://crrev.com/7f7cf4e0b43486fd153cc2922332f2eb7e89d111/device/vr/android/gvr/gvr_device.h
[modify] https://crrev.com/7f7cf4e0b43486fd153cc2922332f2eb7e89d111/device/vr/android/java/src/org/chromium/device/vr/NonPresentingGvrContext.java
[modify] https://crrev.com/7f7cf4e0b43486fd153cc2922332f2eb7e89d111/third_party/gvr-android-sdk/display_synchronizer_jni.h

Comment 3 by mthiesse@chromium.org, Mar 14 2018

Status: Fixed (was: Assigned)

Comment 4 by dougman@chromium.org, Mar 14 2018

Labels: Test-Complete

Comment 5 by btebbs@chromium.org, Jul 4

Components: Internals>XR

Comment 6 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment