New issue
Advanced search Search tips

Issue 818749 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Don't send control-deep-sleep commands to cr50

Project Member Reported by apronin@chromium.org, Mar 5 2018

Issue description

Cr50 currently ignores requests to enable/disable deep-sleep by sending a vendor-specific command. stop sending those commands from cr50 drivers.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 6 2018

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e18811d26ec663c2b9c608ec880dddb69bcb06a5

commit e18811d26ec663c2b9c608ec880dddb69bcb06a5
Author: Andrey Pronin <apronin@chromium.org>
Date: Tue Mar 06 02:34:32 2018

CHROMIUM: tpm: Don't send control-deep-sleep for cr50

Cr50 currently ignores requests to enable/disable deep-sleep by sending
a vendor-specific command. Stop sending those commands from cr50
drivers.

BUG= chromium:818749 
BUG=chromium:764046
TEST=Go through suspend-to-memory and resume, check system log for
     messages like "tpm tpm0: A TPM error (1407) occurred disabling
     deep-sleep". No messages after applying the patch.

Change-Id: I731b89bac39324f63f069eceee32d30a5062ae2c
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/949456
Reviewed-by: Duncan Laurie <dlaurie@google.com>

[modify] https://crrev.com/e18811d26ec663c2b9c608ec880dddb69bcb06a5/drivers/char/tpm/cr50_spi.c
[modify] https://crrev.com/e18811d26ec663c2b9c608ec880dddb69bcb06a5/drivers/char/tpm/cr50_i2c.c
[modify] https://crrev.com/e18811d26ec663c2b9c608ec880dddb69bcb06a5/drivers/char/tpm/cr50.c
[modify] https://crrev.com/e18811d26ec663c2b9c608ec880dddb69bcb06a5/drivers/char/tpm/cr50.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2018

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e302a79212f507a1db4f097b69bea314579a67d4

commit e302a79212f507a1db4f097b69bea314579a67d4
Author: Andrey Pronin <apronin@chromium.org>
Date: Wed Mar 07 06:38:04 2018

CHROMIUM: tpm: Don't send control-deep-sleep for cr50

Cr50 currently ignores requests to enable/disable deep-sleep by sending
a vendor-specific command. Stop sending those commands from cr50
drivers.

BUG= chromium:818749 
BUG=chromium:764046
TEST=build

Change-Id: I731b89bac39324f63f069eceee32d30a5062ae2c
Signed-off-by: Andrey Pronin <apronin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/950129
Reviewed-by: Duncan Laurie <dlaurie@google.com>

[modify] https://crrev.com/e302a79212f507a1db4f097b69bea314579a67d4/drivers/char/tpm/cr50_spi.c
[modify] https://crrev.com/e302a79212f507a1db4f097b69bea314579a67d4/drivers/char/tpm/cr50_i2c.c
[modify] https://crrev.com/e302a79212f507a1db4f097b69bea314579a67d4/drivers/char/tpm/cr50.c
[modify] https://crrev.com/e302a79212f507a1db4f097b69bea314579a67d4/drivers/char/tpm/cr50.h

Status: Fixed (was: Untriaged)

Sign in to add a comment