Long-pressing new-style notification doesn't trigger the inline-setting |
|||
Issue descriptionChrome Version: ToT OS: Chrome OS What steps will reproduce the problem? (1) Show non-ARC notification as a popup or on the message center (2) Long press it by mouse or touch What is the expected result? Inline setting should be shown What happens instead? Nothing happens, or the default action of the notification is triggered Please use labels and text to provide additional information. I'm not sure if it's regression or not. It looks the feature is not implemented yet? For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 6 2018
,
Mar 6 2018
This is not implemented yet. ET_GESTURE_LONG_TAP is a event type for long press by touch, but there is no event type for long press by mouse. I think we need to implement only the feature triggered by gesture event.
,
Mar 6 2018
Not certain how hard it is to implement the feature for mouse, but it's OK to start from touch one as the feature is especially useful on touch devices.
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5984fd63967fd1d2c5ff72bfc6dbe924b232fe4 commit f5984fd63967fd1d2c5ff72bfc6dbe924b232fe4 Author: Megumi Hattori <megumihattori@google.com> Date: Thu Mar 08 06:11:27 2018 Trigger inline settings on notifications by long tap. The inline settings should be triggered by long tap. BUG= 818734 TEST=manual Change-Id: Ieeb7a0c009b15157bd90c823ece84ed39bf676eb Reviewed-on: https://chromium-review.googlesource.com/950504 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#541730} [modify] https://crrev.com/f5984fd63967fd1d2c5ff72bfc6dbe924b232fe4/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/f5984fd63967fd1d2c5ff72bfc6dbe924b232fe4/ui/message_center/views/notification_view_md.h
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d2b9806a5b21bfdfaccc0fcde89b45f1d8eaa51 commit 1d2b9806a5b21bfdfaccc0fcde89b45f1d8eaa51 Author: Megumi Hattori <megumihattori@google.com> Date: Mon Mar 19 08:13:28 2018 Trigger inline settings on notifications by mouse long click. The inline settings should be triggered by mouse long click. BUG= 818734 TEST=manual Change-Id: Iab3c522e86a187bef92276bb5776f0937bbd75ae Reviewed-on: https://chromium-review.googlesource.com/962556 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#543987} [modify] https://crrev.com/1d2b9806a5b21bfdfaccc0fcde89b45f1d8eaa51/ui/message_center/BUILD.gn [modify] https://crrev.com/1d2b9806a5b21bfdfaccc0fcde89b45f1d8eaa51/ui/message_center/views/message_view.cc [modify] https://crrev.com/1d2b9806a5b21bfdfaccc0fcde89b45f1d8eaa51/ui/message_center/views/message_view.h [modify] https://crrev.com/1d2b9806a5b21bfdfaccc0fcde89b45f1d8eaa51/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/1d2b9806a5b21bfdfaccc0fcde89b45f1d8eaa51/ui/message_center/views/notification_view_md.h
,
Mar 20 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by megumihattori@google.com
, Mar 6 2018