New issue
Advanced search Search tips

Issue 818713 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jul 11
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

28.1% regression in scheduler.tough_scheduling_cases at 540504:540547

Project Member Reported by rmcilroy@chromium.org, Mar 5 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=818713

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=df8298834b15d64a06723376e43136448e17c4f64fff469dcb925774a121e48b


Bot(s) for this bug's original alert(s):

chromium-rel-win7-x64-dual
Cc: kenrb@chromium.org jonr...@chromium.org kylec...@chromium.org piman@chromium.org
Owner: jonr...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/128650dc440000

Rate Limit RenderFrameMetadataObserver by jonross@chromium.org
https://chromium.googlesource.com/chromium/src/+/13c8861d8d297b2dcb54b7a68eda0d09a6ea2c0e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/139e0bc2440000
Owner: ----
Status: Untriaged (was: Assigned)
I've ran a pinpoint job where LayerTreeHostImpl doesn't call into RenderFrameMetadataObserver. This removes executing all code in the blamed change in #3.

I'm going to kick off a new bisect to see if it can find something else.
I've also expanded the bisect range as it was only covering the middle of a large spike up. Now 540503-540669
Owner: jonr...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/16b24e62440000

Rate Limit RenderFrameMetadataObserver by jonross@chromium.org
https://chromium.googlesource.com/chromium/src/+/13c8861d8d297b2dcb54b7a68eda0d09a6ea2c0e

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14e14ba6440000

Not for Review - Pinpoint revert RFMO rate limit by jonross@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/956409/2

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: ----
Status: Untriaged (was: Assigned)
The pinpoint shows no difference after the revert. Similar to the results from when I just disabled the algorithm
Cc: simonhatch@chromium.org dtu@chromium.org sullivan@chromium.org
+dtu, can you take a look here? See #12.

Comment 14 by dtu@chromium.org, Mar 16 2018

Looks like the full revert jobs failed because the patch didn't apply cleanly. I'm going to re-try the Pinpoint jobs with a rebased revert. (https://chromium-review.googlesource.com/c/chromium/src/+/965404)
Project Member

Comment 17 by 42576172...@developer.gserviceaccount.com, Mar 16 2018

Owner: dtu@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/179147a1440000

Revert "Rate Limit RenderFrameMetadataObserver" by dtu@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/965404/2

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 18 by 42576172...@developer.gserviceaccount.com, Mar 16 2018

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/17f2505e440000

Revert "Rate Limit RenderFrameMetadataObserver" by dtu@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/965404/2

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: jonr...@chromium.org
Assigning back to jonross: The try job in #18 reproduces the regression after the patch applied cleanly.
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12ab5ffaa40000

All of the runs failed. The most common error (10/20 runs) was:
RunTestError: There are no bots available to run the test.
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1697cff4a40000

All of the runs failed. The most common error (10/20 runs) was:
RunTestError: There are no bots available to run the test.
Sorry, those bots have moved to a different Swarming server. I've updated the configs. Please try again!
Will do, thanks for the info!
😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/13c7148aa40000

All of the runs failed. The most common error (1/20 runs) was:
IOError: [Errno 2] No such file or directory: 'c:\\b\\s\\w\\itogjfbx\\tmpxswmbgtelemetry\\histograms.json'
Status: WontFix (was: Assigned)
So this metric apparently no longer exists. It was last ran April 25th.

There's been quite a bit of work done in this area since the initial patch that was flagged. I haven't seen other thread times/queueing metrics regress.

I'm marking as WontFix since this metric is obsolete.

Sign in to add a comment