Issue metadata
Sign in to add a comment
|
7.3% regression in system_health.memory_mobile at 540729:540739 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 5 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/15818254440000
,
Mar 6 2018
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/15818254440000
,
Mar 7 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14adbb2a440000
,
Mar 9 2018
📍 Found significant differences after each of 4 commits. https://pinpoint-dot-chromeperf.appspot.com/job/14adbb2a440000 [builtins] Refactor the StringConstructor builtin by mathias@chromium.org https://chromium.googlesource.com/v8/v8/+/15e207b300bf7f7b70df83e98cbaf8c0d99a7485 [runtime] Move validity cell from PrototypeInfo to Map. by ishell@chromium.org https://chromium.googlesource.com/v8/v8/+/40a3e6dcb9bdb5cb2a7f6e29fa8e4de75e538ef6 [runtime] Always store the name in a function's ScopeInfo by cbruni@chromium.org https://chromium.googlesource.com/v8/v8/+/01488b9c4f1b4c8e2b66494b24d7e7ff8a826860 [ic] Introduce new IC for storing into array literals. by neis@chromium.org https://chromium.googlesource.com/v8/v8/+/2e2860f74f9c610d5ffb3ee1778d937055d25dea Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Mar 12 2018
My CL (biggest regression) is expected to temporarily regress memory (with the CL a function's name is stored both on the SharedFunctionInfo and the ScopeInfo). Future CLs will deduplicate the name field and only store it once. I think the same counts for ishell@'s CL.
,
Mar 19 2018
,
Mar 22 2018
The actual regression on washingtonpost is 1.2%, browse_social just seems to have gotten noiser.
,
Mar 22 2018
,
Apr 3 2018
,
May 29 2018
Detaching the JSFunction from the Context made up for this regression by large: https://chromeperf.appspot.com/report?sid=233f8c36f9dd5a69f8f09496fa1341181f9d972def0f6650e06fb99b7fdbf927&start_rev=554384&end_rev=556392 ~ 2.28% improvement overall for the later change ~ 1.7% improvement for the later change vs the 1% regression introduced by my cl on washingtonpost. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Mar 5 2018