New issue
Advanced search Search tips

Issue 818712 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocked on:
issue v8:7066



Sign in to add a comment

7.3% regression in system_health.memory_mobile at 540729:540739

Project Member Reported by rmcilroy@chromium.org, Mar 5 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=818712

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=c339b4b082eb78b7334fbe262bd994fca400040a05d30e569625cf6771ea203a


Bot(s) for this bug's original alert(s):

android-nexus6
📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/15818254440000
Cc: bmeu...@chromium.org ishell@chromium.org neis@chromium.org cbruni@chromium.org mathias@chromium.org mythria@chromium.org
Owner: neis@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 4 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14adbb2a440000

[builtins] Refactor the StringConstructor builtin by mathias@chromium.org
https://chromium.googlesource.com/v8/v8/+/15e207b300bf7f7b70df83e98cbaf8c0d99a7485

[runtime] Move validity cell from PrototypeInfo to Map. by ishell@chromium.org
https://chromium.googlesource.com/v8/v8/+/40a3e6dcb9bdb5cb2a7f6e29fa8e4de75e538ef6

[runtime] Always store the name in a function's ScopeInfo by cbruni@chromium.org
https://chromium.googlesource.com/v8/v8/+/01488b9c4f1b4c8e2b66494b24d7e7ff8a826860

[ic] Introduce new IC for storing into array literals. by neis@chromium.org
https://chromium.googlesource.com/v8/v8/+/2e2860f74f9c610d5ffb3ee1778d937055d25dea

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 6 by cbruni@chromium.org, Mar 12 2018

Owner: cbruni@chromium.org
My CL (biggest regression) is expected to temporarily regress memory (with the CL a function's name is stored both on the SharedFunctionInfo and the ScopeInfo). Future CLs will deduplicate the name field and only store it once.

I think the same counts for ishell@'s CL.

Comment 7 by cbruni@chromium.org, Mar 19 2018

Components: Blink>JavaScript

Comment 8 by cbruni@chromium.org, Mar 22 2018

The actual regression on washingtonpost is 1.2%, browse_social just seems to have gotten noiser.

Comment 9 by cbruni@chromium.org, Mar 22 2018

Blockedon: v8:7066
Status: Started (was: Assigned)
Status: WontFix (was: Started)
Detaching the JSFunction from the Context made up for this regression by large:

https://chromeperf.appspot.com/report?sid=233f8c36f9dd5a69f8f09496fa1341181f9d972def0f6650e06fb99b7fdbf927&start_rev=554384&end_rev=556392

~ 2.28% improvement overall for the later change
~ 1.7% improvement for the later change  vs the 1% regression introduced by my cl on washingtonpost.

Sign in to add a comment