New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818696 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 757440



Sign in to add a comment

11%-16.1% regression in blink_perf.parser at 539782:539993

Project Member Reported by rmcilroy@chromium.org, Mar 5 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=818696

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=21e06ad5383a18d60f54a6d8fb7bb3e582d1cdfc4c593d8912f915edade9a8a7


Bot(s) for this bug's original alert(s):

chromium-rel-win8-dual
linux-release
Cc: mstensho@chromium.org eirage@chromium.org keishi@chromium.org mlippautz@chromium.org rch@chromium.org dgro...@chromium.org nzolghadr@chromium.org haraken@chromium.org rhalavati@chromium.org dtapu...@chromium.org
Owner: eirage@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 4 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/1195815c440000

Oilpan: Emit write barrier on collection backing assignment by keishi@chromium.org
https://chromium.googlesource.com/chromium/src/+/d0e0bb6ae37606fdb8b19bab4714706af7580088

Add traffic annotation to required arguments to SpdyStream. by rhalavati@chromium.org
https://chromium.googlesource.com/chromium/src/+/ead4271f098dd2038ec8514f1bf9b59f83b0774b

[css-tables] Test that tables have box-sizing:border-box by default by dgrogan@chromium.org
https://chromium.googlesource.com/chromium/src/+/88182a1b277a19642a857836461cbf4fa7d64dd8

Do not suppress pointercancel event when dnd by eirage@chromium.org
https://chromium.googlesource.com/chromium/src/+/34552fa720bd55ae7b87cdb4897477a8a4893e79

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: dgro...@chromium.org
not related to my change :)
It's certainly not dgrogan's change, since that CL just adds tests.
Components: Blink>MemoryAllocator>GarbageCollection
Owner: keishi@chromium.org
Sorry this is probably me.
Status: Started (was: Assigned)
Cc: -rhalavati@chromium.org
And sure not me.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b7d320daba402c17ead0e5d69eceaf1dcc7c286

commit 3b7d320daba402c17ead0e5d69eceaf1dcc7c286
Author: Keishi Hattori <keishi@chromium.org>
Date: Thu Mar 08 06:13:32 2018

Oilpan: Hide collection backing write barrier behind the incremental marking flag

Adding the write barrier to collection backings regressed blink_perf.parser by 16%

Bug:  818696 
Change-Id: If964e2ccf39beb3010063bf785e97c60ddf007c2
Reviewed-on: https://chromium-review.googlesource.com/953443
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541733}
[modify] https://crrev.com/3b7d320daba402c17ead0e5d69eceaf1dcc7c286/third_party/WebKit/Source/platform/heap/HeapAllocator.h

Blocking: 757440
Cc: alexilin@chromium.org rhalavati@chromium.org csharrison@chromium.org agl@chromium.org lizeb@chromium.org jwd@chromium.org bauerb@chromium.org
 Issue 818671  has been merged into this issue.
Status: Fixed (was: Started)
Performance seems to have recovered.
https://chromeperf.appspot.com/group_report?bug_id=818696

Sign in to add a comment