New issue
Advanced search Search tips

Issue 818691 link

Starred by 3 users
Status: Fixed
Owner:
ikilpatrick@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Remove -webkit-box-flex-group, -webkit-box-lines, % values of -webkit-line-clamp

Project Member Reported by ikilpatrick@chromium.org, Mar 5 2018 
As above, this bug covers an intent to remove for:

-webkit-box-flex-group
-webkit-box-lines
% values of -webkit-line-clamp.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dc2379d58e26905dd77c56617d0baf9972581eb

commit 7dc2379d58e26905dd77c56617d0baf9972581eb
Author: Ian Kilpatrick <ikilpatrick@chromium.org>
Date: Sat Mar 10 02:08:22 2018

Remove %-values of -webkit-line-clamp

As above. Removes all relevant code, and layout-tests for this feature.

See intent to deprecate and remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-e92az54B4I/SZdhGR19DgAJ

Bug:  818691 
Change-Id: Ib39061c2181e142d3122ec0892746266ab06ccda
Reviewed-on: https://chromium-review.googlesource.com/956619
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542316}
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/LayoutTests/fast/overflow/line-clamp.html
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/line-clamp-expected.png
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/line-clamp-expected.png
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/LayoutTests/platform/win/fast/overflow/line-clamp-expected.png
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/Source/core/css/properties/longhands/WebkitLineClampCustom.cpp
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/Source/core/style/BUILD.gn
[modify] https://crrev.com/7dc2379d58e26905dd77c56617d0baf9972581eb/third_party/WebKit/Source/core/style/ComputedStyle.h
[delete] https://crrev.com/b513507ce49d8c1e6ef058f45082f8d2331c9833/third_party/WebKit/Source/core/style/LineClampValue.h
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2750048912d169aa44f7b7155b1c8fbfafcfb57

commit f2750048912d169aa44f7b7155b1c8fbfafcfb57
Author: Ian Kilpatrick <ikilpatrick@chromium.org>
Date: Tue Mar 13 21:55:43 2018

Remove -webkit-box-lines property

As above. Removes all relevant code, and layout-tests for this feature.

See intent to deprecate and remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-e92az54B4I/SZdhGR19DgAJ

Bug:  818691 
Change-Id: I67fded35309d6cfa52ff462f977d5ebef1f4e1e9
Reviewed-on: https://chromium-review.googlesource.com/957264
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542925}
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/LayoutTests/fast/deprecated-flexbox/intrinsic-min-width-applies-with-fixed-width.html
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/css/CSSPropertiesRanking.json5
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/css/CSSValueKeywords.json5
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/css/parser/CSSProtoConverter.cpp
[delete] https://crrev.com/ab08b82f4fa2710ed0258dc0cc39a7460b070655/third_party/WebKit/Source/core/css/properties/longhands/WebkitBoxLinesCustom.cpp
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.h
[modify] https://crrev.com/f2750048912d169aa44f7b7155b1c8fbfafcfb57/third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51dff7d18820e3e661bc2c3b1070f58619731b2d

commit 51dff7d18820e3e661bc2c3b1070f58619731b2d
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Wed Mar 14 02:24:59 2018

Remove obsolete webkit_box_lines.h reference

This is causing ninja to treat WebKit as dirty on every compile, for
certain build configurations. Follow-up to https://crrev.com/c/957264.

Bug:  818691 
Change-Id: Idd32f722b8d4efe82388a06e2acc0d638cd9eb4e
Reviewed-on: https://chromium-review.googlesource.com/961784
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542988}
[modify] https://crrev.com/51dff7d18820e3e661bc2c3b1070f58619731b2d/third_party/WebKit/Source/core/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edcaa42b78d784492c60379322c8697102fe13a8

commit edcaa42b78d784492c60379322c8697102fe13a8
Author: Ian Kilpatrick <ikilpatrick@chromium.org>
Date: Wed Mar 14 18:30:42 2018

Remove -webkit-box-flex-group property.

As above. Removes all relevant code, and layout-tests for this feature.

See intent to deprecate and remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-e92az54B4I/SZdhGR19DgAJ

Bug:  818691 
Change-Id: Idd0ca424071aadc7cb5ba9924888452ff1fab340
Reviewed-on: https://chromium-review.googlesource.com/956275
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543134}
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[delete] https://crrev.com/399596574b02327009504057a48c497397aef43e/third_party/WebKit/LayoutTests/fast/deprecated-flexbox/020.html
[delete] https://crrev.com/399596574b02327009504057a48c497397aef43e/third_party/WebKit/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm
[delete] https://crrev.com/399596574b02327009504057a48c497397aef43e/third_party/WebKit/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-001.htm
[delete] https://crrev.com/399596574b02327009504057a48c497397aef43e/third_party/WebKit/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm
[delete] https://crrev.com/399596574b02327009504057a48c497397aef43e/third_party/WebKit/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-002.htm
[delete] https://crrev.com/399596574b02327009504057a48c497397aef43e/third_party/WebKit/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm
[delete] https://crrev.com/399596574b02327009504057a48c497397aef43e/third_party/WebKit/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-003.htm
[delete] https://crrev.com/399596574b02327009504057a48c497397aef43e/third_party/WebKit/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm
[delete] https://crrev.com/399596574b02327009504057a48c497397aef43e/third_party/WebKit/LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-004.htm
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/Source/core/css/CSSPropertiesRanking.json5
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/Source/core/css/parser/CSSProtoConverter.cpp
[delete] https://crrev.com/399596574b02327009504057a48c497397aef43e/third_party/WebKit/Source/core/css/properties/longhands/WebkitBoxFlexGroupCustom.cpp
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/edcaa42b78d784492c60379322c8697102fe13a8/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.h

Comment 5 by ikilpatrick@chromium.org, Mar 15 2018

Status: Fixed (was: Assigned)

Comment 6 by laukst...@gmail.com, Mar 15 2018 

Wouldn't this stop "multiple-line ellipsis" https://github.com/w3c/csswg-drafts/issues/390 workaround before supported proposed spec?

Comment 7 by ikilpatrick@chromium.org, Mar 15 2018 

Hi laukstein,

Thanks for asking.

In short no. This remove *percentage* values for -webkit-line-clamp, *number* values will still work. E.g.

-webkit-line-clamp: 2; /* works */
-webkit-line-clamp: 80%; /* no longer works */

(The other properties in this removal have no effect on -webkit-line-clamp).
We added a UseCounter for %-values for -webkit-line-clamp and it has effectively no usage.
https://www.chromestatus.com/metrics/feature/timeline/popularity/2139

Let us know if you have any other questions.
Thanks,
Ian
►

Sign in to add a comment