Once OOPIF is lunched, the renderer side UseCounters will no longer report correctly. So we will need to move all UseCounters (features, CSS features, extension, SVG documents) to the browser-side to report correctly.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29d922d6f2e2da999f1c71b320a65c2584a01d99 commit 29d922d6f2e2da999f1c71b320a65c2584a01d99 Author: Luna Lu <loonybear@chromium.org> Date: Tue Mar 27 18:06:51 2018 Plumb UseCounter histograms for CSS properties and animated CSS properties to the browser side Bug: 818684 Change-Id: I6358926667c913988fab0ca4a39f25cbc4f04734 Reviewed-on: https://chromium-review.googlesource.com/969076 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#546163} [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.cc [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.h [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/chrome/common/page_load_metrics/page_load_metrics.mojom [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/chrome/test/data/page_load_metrics/use_counter_features.html [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/content/public/renderer/render_frame_observer.h [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/content/renderer/render_frame_impl.cc [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/content/renderer/render_frame_impl.h [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/Source/core/frame/LocalFrameClient.h [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/Source/core/frame/PRESUBMIT.py [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/Source/core/frame/UseCounter.cpp [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/Source/core/frame/UseCounter.h [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/Source/core/frame/UseCounterTest.cpp [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/public/mojom/BUILD.gn [add] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/public/mojom/use_counter/OWNERS [add] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/public/mojom/use_counter/css_property_id.mojom [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/third_party/WebKit/public/web/WebFrameClient.h [modify] https://crrev.com/29d922d6f2e2da999f1c71b320a65c2584a01d99/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed9859e051fd0175204cbb8a0efb2cefc20790de commit ed9859e051fd0175204cbb8a0efb2cefc20790de Author: Luna Lu <loonybear@chromium.org> Date: Tue Jun 12 22:51:22 2018 Rename use counter css property histograms Recently verified the measurement align, cases with very different counts are due to OOPIF. Moving the CSS histograms to page load metrics. Tests RecordingFeatures, RecodingCSSProperties, RecordingAnimatedCSSProperties are removed because there are browser tests testing the browser side histograms already. Test MutedDocuments is removed but the page load metrics takes care of internal pages, non http/https url, ntp, etc Test InspectorDisablesMeasurement is being tested in inspector layout test instead. Bug: 818684 Change-Id: I822b412cf34e5ccb9bda13b26ba33cbe05217ea3 Reviewed-on: https://chromium-review.googlesource.com/1089031 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#566614} [modify] https://crrev.com/ed9859e051fd0175204cbb8a0efb2cefc20790de/chrome/browser/page_load_metrics/observers/use_counter_page_load_metrics_observer.h [modify] https://crrev.com/ed9859e051fd0175204cbb8a0efb2cefc20790de/third_party/blink/renderer/core/frame/use_counter.cc [modify] https://crrev.com/ed9859e051fd0175204cbb8a0efb2cefc20790de/third_party/blink/renderer/core/frame/use_counter_test.cc [modify] https://crrev.com/ed9859e051fd0175204cbb8a0efb2cefc20790de/tools/metrics/histograms/histograms.xml
Comment 1 by loonyb...@chromium.org
, Mar 5 2018