New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818671 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 818696
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.1%-21% regression in blink_perf.parser at 539725:539891

Project Member Reported by rmcilroy@chromium.org, Mar 5 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=818671

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=07aef59bdb219baa891d308a011a2619913456dc2121334603792e19cf68d150


Bot(s) for this bug's original alert(s):

android-one
chromium-rel-win8-dual
Cc: bauerb@chromium.org lizeb@chromium.org keishi@chromium.org mlippautz@chromium.org csharrison@chromium.org alexilin@chromium.org jwd@chromium.org haraken@chromium.org rhalavati@chromium.org agl@chromium.org
Owner: agl@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 3 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14c2f0dc440000

predictors: Remove ResourcePrefetchPredictor by alexilin@chromium.org
https://chromium.googlesource.com/chromium/src/+/b5ea1fe654f7e0e71704dc278ccd0b5c5cab7a8a

Oilpan: Emit write barrier on collection backing assignment by keishi@chromium.org
https://chromium.googlesource.com/chromium/src/+/d0e0bb6ae37606fdb8b19bab4714706af7580088

Revert "Revert "webauthn: support the appid extension."" by agl@chromium.org
https://chromium.googlesource.com/chromium/src/+/dc639a910dd43a1c1ff88715f092669e5f57878a

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by agl@chromium.org, Mar 9 2018

Owner: keishi@chromium.org
From the pinpoint page, only "Oilpan: Emit write barrier on collection backing assignment" appears to have a visually-significant impact. But the impact is downwards so I'm not sure whether it's good or bad.

The other two nominated changes (which includes mine) appear to be in the noise from what I can tell. "predictors: Remove ResourcePrefetchPredictor" is accompanied by an abnormally wide error bar and mine ("Revert "Revert "webauthn: support the appid extension."") drifts back up to the previous level over the next few revisions.

Thus I'm reassigning to keishi because their change is the dominant one.

Comment 5 by keishi@chromium.org, Mar 10 2018

Mergedinto: 818696
Status: Duplicate (was: Assigned)

Sign in to add a comment