New issue
Advanced search Search tips

Issue 818661 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Merge ENABLE_VR into a single buildflag

Project Member Reported by cjgrant@chromium.org, Mar 5 2018

Issue description

Context:

sky@: I'm in the process of making all our buildflag_headers have a similar name. In doing this I noticed ENABLE_VR is in a number of buildflags. Did you consider putting it in a more central location so that you don't need to duplicate it in a number of build files?

cjgrant@: At this point, we probably ought to be more central.  My guess here is that when the feature was initially added, the flag was contained to a single directory, and didn't warrant a central location.  Michael, if you have no objection, I'll file a bug to do this de-duping for M-67/68.  ...  Scott, does that sound okay for now?

mthiesse@:  SGTM

sky@: Yes. There is no rush here.
 
Labels: Hotlist-VRB-TD
Labels: -M-68 M-69

Comment 3 by samdrazin@chromium.org, Today (17 hours ago)

Labels: -Type-Bug -M-69 Type-Task

Comment 4 by ddorwin@chromium.org, Today (17 hours ago)

Components: Internals>XR
Labels: -Proj-VR XR-TD

Sign in to add a comment