New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 818624 link

Starred by 1 user
Status: Fixed
Owner:
█ mitchfoley@chromium.org
Last visit > 30 days ago
Closed: Jan 4
Cc:
jochen@chromium.org
█ fdegros@chromium.org
█ mitchfoley@chromium.org
█ martiw@chromium.org
█ ichikawa@chromium.org
█ dvallet@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 39240



Sign in to add a comment

third_party/ink has no OWNERS or README.chromium

Project Member Reported by raphael....@intel.com, Mar 5 2018 
//tools/licenses.py is currently failing with

    licenses.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES entry in third_party/ink                                                                                       

It'd be good practice to have an OWNERS file and a README.chromium with additional information.

Right now I don't really know who to CC in this bug, but at least the rest of the public tree does not seem to reference third_party/ink, so I am assuming it is not used in Chromium.

Comment 1 by raphael....@intel.com, Mar 5 2018

Cc: fdegros@chromium.org

Comment 2 by dtapu...@chromium.org, Mar 9 2018

Owner: mitchfoley@chromium.org
Status: Assigned (was: Available)
Mitch can you add yourself as an OWNER on this directory?

Comment 3 by mitchfoley@chromium.org, Mar 19 2018

Cc: jochen@chromium.org
I attempted to do this awhile ago but was rejected: https://chromium-review.googlesource.com/c/chromium/src/+/848084.

Comment 4 by jochen@chromium.org, Mar 20 2018 

for other third party repos, we also don't add upstream authors that aren't chromium committers.

Comment 5 by fdegros@chromium.org, Mar 21 2018 

Smells like a big red tape.

So, if I understand correctly, Ink authors, which are experts of this library and have worked on it for several years in Google3, cannot control and be marked as OWNERS of third_party/ink where they plan to deliver this library to Chrome and ChromeOS users (including the "essential apps" team which I'm part of).

Is this description correct?

This looks like an impediment. This is hurting our progress.

Jochen, can you propose a solution?

Comment 6 by fdegros@chromium.org, Mar 21 2018

Cc: martiw@chromium.org dvallet@chromium.org

Comment 7 by fdegros@chromium.org, Mar 21 2018 

Also, in response to your comment "you could just open source ink" in change 848084: As far as I understand, open-sourcing Ink is not trivial. It might be done in the future, but as a temporary measure, we'll have to live with precompiled binary drops.

Comment 8 by jochen@chromium.org, Mar 21 2018 

I advised you initially during the eng review to opensource ink, and you decided that it's not worth the effort. Now you're running into the problems I told you about. I'm not sure what you expected?

Also, it's a closed source blob, if there was any work for you to do in chromium, you'd be a committer by now (it only requires 20 non trivial changes), so I'm not sure how that's hurting your process?

If you need help with opensourcing ink, various chrome engineers repeatedly offered help.

Also note that ink is restricted to chrome os, there's no delivering it to chrome.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73c6c3654556a90131b69a9d7f452048238dfc98

commit 73c6c3654556a90131b69a9d7f452048238dfc98
Author: François Degros <fdegros@chromium.org>
Date: Fri Mar 23 00:14:12 2018

Added third_party/ink/OWNERS file.

Change-Id: I9e9093094746aff066b97f5e66e68b68ae4e15b1
Bug:  818624 
Reviewed-on: https://chromium-review.googlesource.com/967966
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545300}
[add] https://crrev.com/73c6c3654556a90131b69a9d7f452048238dfc98/third_party/ink/OWNERS
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9e924b9c32968758215e20a9341a3bfe40fba86

commit e9e924b9c32968758215e20a9341a3bfe40fba86
Author: François Degros <fdegros@chromium.org>
Date: Tue Mar 27 03:56:01 2018

Added third_party/ink/README.md

Change-Id: I3ed4309a790d09d1568ebfa0e32788f22ecfcef0
Bug:  818624 
Reviewed-on: https://chromium-review.googlesource.com/977461
Reviewed-by: Marti Wong <martiw@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546003}
[add] https://crrev.com/e9e924b9c32968758215e20a9341a3bfe40fba86/third_party/ink/README.md

Comment 11 by fdegros@chromium.org, Mar 27 2018

Status: Fixed (was: Assigned)

Comment 12 by raphael....@intel.com, Mar 28 2018

Owner: fdegros@chromium.org
Status: Assigned (was: Fixed)
Sorry, but the error persists since you didn't add a README.chromium (the OWNERS commit is very helpful though):

    third_party/ink: missing README.chromium or licenses.py SPECIAL_CASES entry in third_party/ink

Comment 13 by fdegros@chromium.org, Mar 28 2018 

What should README.chromium contain?
Would it be Ok to simply rename the README.md to README.chromium?

Comment 14 by raphael....@intel.com, Mar 29 2018 

Please see https://cs.chromium.org/chromium/src/third_party/README.chromium.template for what it's supposed to look like.

Comment 15 by fdegros@chromium.org, Apr 4 2018

Owner: mitchfoley@chromium.org

Comment 16 by raphael....@intel.com, Aug 8

Blocking: 39240
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4719c07770100e25172510926b5ff5c3874e3bf4

commit 4719c07770100e25172510926b5ff5c3874e3bf4
Author: dstockwell <dstockwell@google.com>
Date: Thu Jan 03 23:26:56 2019

third_party/ink: remove stale files and prepare for new artifacts

Ink is now open source at https://github.com/google/ink. As discussed
in go/ink-in-chromium the short term plan is to include build artifacts
based on those sources rather than attempt to produce as part of the
chromium build.

That strategy is demonstrated in https://chromium-review.googlesource.com/c/chromium/src/+/1393204

Bug: 902646,  818624 
Change-Id: I65f0e3eeb406f72c8c26fb71c4de846c557ba17c
Reviewed-on: https://chromium-review.googlesource.com/c/1393583
Reviewed-by: François Degros <fdegros@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619802}
[add] https://crrev.com/4719c07770100e25172510926b5ff5c3874e3bf4/third_party/ink/LICENSE
[add] https://crrev.com/4719c07770100e25172510926b5ff5c3874e3bf4/third_party/ink/README.chromium
[modify] https://crrev.com/4719c07770100e25172510926b5ff5c3874e3bf4/third_party/ink/README.md
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/array/array.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/asserts/asserts.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/base.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/crypt/base64.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/crypt/crypt.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/debug/debug.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/debug/entrypointregistry.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/debug/error.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/debug/errorcontext.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/disposable/disposable.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/disposable/idisposable.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/dom/asserts.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/dom/browserfeature.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/dom/classlist.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/dom/dom.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/dom/htmlelement.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/dom/nodetype.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/dom/safe.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/dom/tagname.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/dom/tags.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/dom/vendor.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/browserevent.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/browserfeature.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/event.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/eventhandler.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/eventid.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/events.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/eventtarget.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/eventtype.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/keycodes.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/listenable.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/listener.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/listenermap.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/events/wheelevent.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/format/format.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/fs/url.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/functions/functions.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/html/legacyconversions.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/html/safehtml.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/html/safescript.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/html/safestyle.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/html/safestylesheet.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/html/safeurl.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/html/trustedresourceurl.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/html/uncheckedconversions.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/i18n/bidi.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/i18n/bidiformatter.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/i18n/graphemebreak.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/i18n/uchar.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/iter/iter.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/labs/useragent/browser.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/labs/useragent/engine.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/labs/useragent/platform.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/labs/useragent/util.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/math/box.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/math/coordinate.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/math/irect.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/math/long.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/math/math.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/math/rect.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/math/size.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/object/object.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/proto2/descriptor.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/proto2/fielddescriptor.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/proto2/message.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/proto2/objectserializer.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/proto2/serializer.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/reflect/reflect.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/soy/data.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/soy/soy.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/string/const.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/string/string.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/string/typedstring.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/structs/collection.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/structs/inversionmap.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/structs/map.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/structs/set.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/structs/structs.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/style/style.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/ui/component.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/ui/idgenerator.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/uri/uri.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/uri/utils.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/useragent/product.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/closure/useragent/useragent.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/ink/web/js/canvas_manager/canvas_manager.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/ink/web/js/cursor_updater.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/ink/web/js/embed/embed.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/ink/web/js/embed/embed_component.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/ink/web/js/embed/events.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/ink/web/js/main.soy.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/ink_event.pb.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/ink_scripts.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/nacl/_platform_specific/arm/ink_arm.nexe
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/nacl/_platform_specific/x86-32/ink_x86_32.nexe
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/nacl/_platform_specific/x86-64/ink_x86_64.nexe
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/nacl/index.html
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/nacl/ink.nmf
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/nacl/ink_demo.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/nacl/ink_lib_binary.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/wasm/glcore_base.wasm
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/wasm/index.html
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/wasm/ink_demo.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/prebuilt/wasm/ink_lib_binary.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/proto/animations.pb.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/proto/document.pb.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/proto/elements.pb.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/proto/rect_bounds.pb.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/proto/sengine.pb.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/public/js/common/brush_model.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/public/js/common/color.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/public/js/common/element_listener.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/public/js/common/model.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/public/js/common/proto_serializer.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/public/js/common/undo_state_change_event.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/public/js/common/util.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/public/nacl/embed.soy.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/sketchology/public/nacl/sketchology_engine_wrapper.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/template/soy/soyutils_usegoog.js
[delete] https://crrev.com/b4060ea260b4253863cbf00300396a418304361e/third_party/ink/wireserializer.js

Comment 18 by dstockwell@google.com, Jan 4

Status: Fixed (was: Assigned)
►

Sign in to add a comment