Regression:Focus should stay on 'more actions' icon for export passwords after escaping the export passwords overlay
Reported by
vineetha...@etouch.net,
Mar 5 2018
|
|||||||
Issue descriptionChrome Version: 67.0.3362.0 Revision bc0fc7083e5466f5227bc868c2543957672def9a-refs/heads/master@{#540777}(32/64 bit) OS: Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS) OS Pre-condition: Atleast one saved password entry should be present under chrome://settings/passwords What steps will reproduce the problem? (1) Launch Chrome, navigate to chrome://settings/passwords. (2) Click on more actions icon for export passwords to open overlay. (3) Now press Esc key and observe the focus. Actual Result: Focus should stay on 'more actions' icon for export passwords after escaping the overlay. Expected Result: Focus does not stay on 'more actions' icon for export passwords after escaping the overlay. This is regression issue broken in ‘M-64’ and providing the bisect using per-revision bisect, Good build: 64.0.3274.0(Revision: 518062) Bad build: 64.0.3275.0(Revision: 518486) You are probably looking for a change made after 518219 (known good), but no later than 518220 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/1fe4112ce1462a9c011f19a383149c9674bc8999..92cf740a719c53a1956612ed43f24089aabbcb07 Suspect: https://chromium.googlesource.com/chromium/src/+/92cf740a719c53a1956612ed43f24089aabbcb07 @cfroussios: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. This issue is also seen on M64 Stable(build #64.0.3282.186), M65 Beta(build #65.0.3325.106), M66 Dev(build #66.0.3355.0). 2. 'Password export' flag needs to be enabled under chrome://flags before build #66.0.3336.0 to get the export password option under chrome://settings/passwords Thank You!
,
Mar 9 2018
,
Mar 12 2018
Update : Rechecked the above issue on Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS) OS with latest Canary Chrome version #67.0.3368.0 and the issue is fixed. Kindly refer the attached screen cast for reference.
,
Mar 13 2018
r542097 has been on dev for a few days and is a verified fix. Can we merge?
,
Mar 14 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddf306ecd97e1a3d436b12bf0376d7c7add930d6 commit ddf306ecd97e1a3d436b12bf0376d7c7add930d6 Author: Christos Froussios <cfroussios@chromium.org> Date: Wed Mar 14 18:37:12 2018 [Password Manager] Focus 'More options...' after closing export dialog Focus should return to the item which caused the export modal dialog to be opened, once the dialog is done. Bug: 818619 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0e67519aef1821e751e7dd90bab42b4321408442 Reviewed-on: https://chromium-review.googlesource.com/950774 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#542097}(cherry picked from commit 71cf20d31324ac1e545b7b5994471ad6109f1007) Reviewed-on: https://chromium-review.googlesource.com/963121 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#236} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/ddf306ecd97e1a3d436b12bf0376d7c7add930d6/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
,
Mar 15 2018
Update : Rechecked the above issue on Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS) OS on latest Beta Chrome version #66.0.3359.33 and the issue is fixed. Kindly refer the attached screen cast for reference. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Mar 9 2018