New issue
Advanced search Search tips

Issue 818617 link

Starred by 2 users
Status: Untriaged
Owner: ----
Cc:
danakj@chromium.org
nyerramilli@chromium.org
robliao@chromium.org
rbasuvula@chromium.org
gab@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Glimpse of spinner is observed on import bookmark overlay.

Reported by shruti.j...@etouch.net, Mar 5 2018 
Chrome Version:67.0.3362.0 (Official Build) Revisionbc0fc7083e5466f5227bc868c2543957672def9a-refs/heads/master@{#540777}(32/64-bit) 
OS:Windows (7,8,8.1,10),Linux (14.04 LTS) and Mac OS X(10.12.6,10.13.1,10.13.4)

Steps to reproduce:
(1) Launch chrome and navigate to chrome://settings/importData
(2) Click on import bookmarks and settings and click on import and observe.

Actual Result:Glimpse of spinner is observed on import bookmark overlay.
Expected Result:Glimpse of spinner should not be seen on import bookmark overlay.

This is a regression issue broken in M-62 and using per-revision bisect providing the bisect results,

Good Build:62.0.3178.0 (Revision:492240)
Bad Build:62.0.3179.0(Revision:492477)

You are probably looking for a change made after 492262 (known good), but no later than 492263 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/e6f54b66953e30e4c07a9f30a226a9da71037307..3ff403eecdd23a39853a4ebca52023fbba6c5d00

Suspect:https://chromium.googlesource.com/chromium/src/+/3ff403eecdd23a39853a4ebca52023fbba6c5d00

@Gabriel Charette: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1.Issue is also seen on Stable (build #64.0.3282.186),M-65 Beta (build # 65.0.3325.106) and M-66 Dev (build #66.0.3355.0)
2.As Gabriel Charette is displayed as OOO in the tool, cc'ing the reviewers of the CL. request them to please take a look and assign accordingly.

Please refer the attached screen-cast for your reference.

Thank You!
Actual.mov
2.8 MB View Download
Expected.mov
2.6 MB View Download

Comment 1 by gab@chromium.org, Mar 22 2018

Cc: gab@chromium.org
Components: Internals>PlatformIntegration
Owner: ----
Status: Untriaged (was: Assigned)
The issue is that my change brought back a previous rule that nested message loops do not execute application tasks by default (to prevent undesired reentrancy).

The solution would be to add a base::MessageLoop::ScopedNestableTaskAllower in the scope of this native dialog. But first we have to make sure the stack it's invoked on is reentrancy safe.

Overall I don't know that we care that the spinner runs while the user is making a decision on the modal system dialog, if anything it shows that Chrome is waiting on dialog's result.

Punting to Mac/Windows triage.

Comment 2 by pranjali...@etouch.net, Nov 14

Labels: Hotlist-DesktopUIValid Hotlist-DesktopUIChecked
 "Mass UI Triage"

Just to update: Still we are able to reproduce the issue on Latest canary #72.0.3610.0 on Win(7,8,8.1,10),Linux (14.04 LTS) and Mac OS X(10.13.6,10.13.1,10.14.2).
Please find the screen shot for reference.

Thank You...
Canary behaviour.mp4
261 KB View Download
►

Sign in to add a comment