New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818615 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Unable to clear the site added under Clipboard exception

Reported by kye...@etouch.net, Mar 5 2018

Issue description

Application Version: 66.0.3359.0
Android Build Number: 6.0.1/MMB29K
Device: Samsung Galaxy J7(SM-J700F)

Steps to reproduce: 
1. Launch chrome.
2. Go to Settings from chrome menu > Tap on Site settings> Clipboard.
3. Tap on 'ADD SITE EXCEPTION' > Add any site.
4. Tap on added site > Tap on 'CLEAR & RESET' button > Tap on 'CLEAR & RESET' from dialogue box > Observe.

Observed behavior: 
Unable to clear the site added under Clipboard exception.

Expected behavior: 
User should be able to clear the site added under Clipboard exception.

Frequency: 
<5/5>

Additional comments: 
1.Samsung Galaxy S4(GT-I9500)(5.0.1/LRX22C),Google Pixel(7.1.2/NJH47F),Karbonn Sparkle V(5.1.1/LMY47V),Nexus 7(6.0.1/MOB30X),Nexus 9(7.1.1/N9F27M),Samsung Galaxy J7(SM-J700F)(6.0.1/MMB29K),Samsung Galaxy J2(SM-J200G)(5.1.1/LMY47X),Samsung galaxy Grand2 (SM-G7102)(4.3.0/JLS36C)

Note: 
New change and issue is obserevd from 66.0.3357.0 Build 
 

Comment 1 by kye...@etouch.net, Mar 5 2018

Please find logs and Video @ http://go/chrome-androidlogs1/8/818615
Components: Blink>Editing>Paste Blink>DataTransfer
Labels: -Pri-3 ReleaseBlock-Stable M-66 Pri-1 Type-Bug-Regression
Owner: garykac@chromium.org
Status: Assigned (was: Unconfirmed)
Labels: -Type-Bug-Regression Type-Bug
Description: Show this description
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78e5247d0c91c400ae44f309e88f8a0e70ed14d7

commit 78e5247d0c91c400ae44f309e88f8a0e70ed14d7
Author: Gary Kacmarcik <garykac@chromium.org>
Date: Fri Mar 09 15:29:00 2018

Fix clipboard permission site-exception handling

Remove the "+ Add site exception" button for consistency with other
Content Settings based on origin. The current UX for this action
assumes that the site exception is host-pattern based, so the
exception is not stored/cleared correctly.

Bug:  818615 , 677565
Change-Id: Id47b07ea704c4957f3bb73c2c99629021bc65bd3
Reviewed-on: https://chromium-review.googlesource.com/952574
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542118}
[modify] https://crrev.com/78e5247d0c91c400ae44f309e88f8a0e70ed14d7/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/78e5247d0c91c400ae44f309e88f8a0e70ed14d7/chrome/android/java/strings/android_chrome_strings.grd

Cc: owe...@chromium.org
Labels: Merge-Request-66
Status: Fixed (was: Started)
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 9 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 38 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Note: The .grd change is removing (now unused) strings, not adding any.

Comment 10 by cmasso@google.com, Mar 12 2018

Labels: -Hotlist-Merge-Review -Merge-Review-66 Merge-Approved-66
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 12 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b22411d09006514f50a39b36114a412b42f97d8

commit 2b22411d09006514f50a39b36114a412b42f97d8
Author: Gary Kacmarcik <garykac@chromium.org>
Date: Mon Mar 12 22:41:53 2018

Fix clipboard permission site-exception handling

Remove the "+ Add site exception" button for consistency with other
Content Settings based on origin. The current UX for this action
assumes that the site exception is host-pattern based, so the
exception is not stored/cleared correctly.

Bug:  818615 , 677565
Change-Id: Id47b07ea704c4957f3bb73c2c99629021bc65bd3
Reviewed-on: https://chromium-review.googlesource.com/952574
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#542118}(cherry picked from commit 78e5247d0c91c400ae44f309e88f8a0e70ed14d7)
Reviewed-on: https://chromium-review.googlesource.com/959430
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#182}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/2b22411d09006514f50a39b36114a412b42f97d8/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/2b22411d09006514f50a39b36114a412b42f97d8/chrome/android/java/strings/android_chrome_strings.grd

Status: Verified (was: Fixed)
Verified in 66.0.3359.30 that "+ Add site exception" button is no more available.
Why is this RVG?
Labels: -Restrict-View-Google
#13. No idea. It doesn't seem like it should be. I wonder if it was added by default because it mentions "exception" in the description...

In any case, I'm removing it.

Sign in to add a comment