New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 818608 link

Starred by 2 users
Status: Fixed
Owner:
ilnik@chromium.org
Closed: Mar 2018
Cc:
█ anatolid@chromium.org
mflodman@chromium.org
sprang@chromium.org
brandtr@chromium.org
terelius@chromium.org
holmer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Merge to M66: Reset pacing settings after exiting from screenshare

Project Member Reported by ilnik@chromium.org, Mar 5 2018 
This is a fix for unintended huge video delay if user switches to and from screenshare.

Original bug: https://bugs.chromium.org/p/chromium/issues/detail?id=816930
Fix landed in webrtc: https://webrtc.googlesource.com/src.git/+/9f7e2a90da243288657e1802af85168e87daab01

Which has landed in chrome here: https://chromium.googlesource.com/chromium/src/+/537fc7a7cf2282cfb3fb78ecd86dce5e681a8309
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 6 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by ilnik@chromium.org, Mar 6 2018

Labels: -Merge-Approved-66 Merge-Merged-66 merge-merged-3359
Status: Fixed (was: Assigned)
Merged in webrtc here:
https://webrtc.googlesource.com/src/+/69491c0d6f014a237e55bf325c82e27530ff2fc1

Comment 3 by ilnik@chromium.org, Mar 6 2018

Labels: -Hotlist-Merge-Approved

Comment 4 by jansson@chromium.org, Mar 13 2018

Labels: MissingTests
Could you add a test that verifies this behavior so it does not regress?

Comment 5 by ilnik@chromium.org, Mar 13 2018 

Yes. I've made a tracking bug for adding tests:
https://bugs.chromium.org/p/webrtc/issues/detail?id=9005

Comment 6 by ilnik@chromium.org, Mar 15 2018

Labels: -MissingTests
Tests implemented: https://bugs.chromium.org/p/webrtc/issues/detail?id=9005
►

Sign in to add a comment