New issue
Advanced search Search tips

Issue 818573 link

Starred by 3 users
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Mar 2018
Cc:
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
dgozman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Browser gets crashed after cancelling 'Audit' in dev tools

Reported by db...@etouch.net, Mar 5 2018 
Chrome Version: 67.0.3362.0 Revision bc0fc7083e5466f5227bc868c2543957672def9a-refs/heads/master@{#540777}(32/64 bit) 
OS: Windows(7,8,8.1,10),Linux(14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, open NTP and then open dev tools window.
(2) Navigate to 'Audit' section and click on 'Perform an audits'
(3) Then type chrome://kill in omnibox and now clcik on Cancel button of audit overlay
(4) Observe.

Actual: Browser gets crashed.

Crash id: 287b6ba4df2ff099 (Local Crash ID: 2e06a0fa-6af0-4e6c-9791-290bbeb78bdd)

Expected: Browser should not crash.

This is a regression issue, broken in 'M67', will soon update the other info:

Comment 1 by db...@etouch.net, Mar 5 2018

Labels: -M-67 hasbisect-per-revision FoundIn-66 Target-66 M-65 RegressedIn-65 Target-67 FoundIn-67 Target-65 FoundIn-65 OS-Mac
Owner: jzfeng@chromium.org
Status: Assigned (was: Unconfirmed)
Correction: This is a regression issue, broken in 'M65', and providing bisect using bisect per revision:

Good Build: 65.0.3324.0(Revision: 530028)
Bad Build: 65.0.3325.0(Revision: 530369)

You are probably looking for a change made after 530033 (known good), but no later than 530034 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/3ad51612ce8cd153c47dda9ea3fca5051efbab04..d8720c79319084a462f6db65f58f24be65639815

Suspect: https://chromium.googlesource.com/chromium/src/+/d8720c79319084a462f6db65f58f24be65639815

Note: 1. Issue is also seen on Mac(10.12.6,10.13.1,10.13.4)OS
      2. Issue is also seen on Beta M65 (#65.0.3325.106) and Dev M66(#66.0.3355.0) builds.

Comment 2 by nyerramilli@chromium.org, Mar 5 2018

Labels: ReleaseBlock-Stable
adding RBS, please change if required

Comment 3 by gov...@chromium.org, Mar 5 2018

Cc: pbomm...@chromium.org dgozman@chromium.org

Comment 4 by dgozman@chromium.org, Mar 5 2018

Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Owner: dgozman@chromium.org
I will take a look at this one. Not a blocker given very involved scenario (manually typing chrome://kill during an audit).
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6370718466efa59352e7e9df2a1da2ae433a482

commit c6370718466efa59352e7e9df2a1da2ae433a482
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Mar 06 00:09:39 2018

[DevTools] Fix crash in WebContentsImpl::ClearDeviceEmulationSize

We are accessing null RenderWidgetHostView. Also added a test which
exposed an issue with emulation commands not being processed when
crashed.

Bug:  818573 
Change-Id: Ife852d5323b56d2d08382ef865ac9bf51c5476ff
Reviewed-on: https://chromium-review.googlesource.com/949725
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540998}
[modify] https://crrev.com/c6370718466efa59352e7e9df2a1da2ae433a482/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/c6370718466efa59352e7e9df2a1da2ae433a482/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/c6370718466efa59352e7e9df2a1da2ae433a482/content/browser/web_contents/web_contents_impl.cc

Comment 6 by dgozman@chromium.org, Mar 6 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment