New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818560 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 822912



Sign in to add a comment

Merge TabSwitcherTabGrid flag to UIRefreshPhase1 flag

Project Member Reported by edchin@chromium.org, Mar 5 2018

Issue description

Once the tab grid is functional enough, remove the TabSwitcherTabGrid flag and replace with the UIRefreshPhase1 flag so that it can be tested together.
 
Cc: cma...@chromium.org
Labels: Q1 S-See-Open-Tabs
Making this a Q1 goal so that we can have more people testing sooner.
Labels: small

Comment 3 by edchin@chromium.org, Mar 21 2018

CL is in-flight. 

Comment 4 by edchin@chromium.org, Mar 21 2018

Status: Started (was: Assigned)

Comment 5 by edchin@chromium.org, Mar 21 2018

Blockedon: 822912

Comment 6 by edchin@chromium.org, Mar 21 2018

This is blocked due to a bug that causes any egtests with the tab grid turned on to fail. 

See the bot failures on this CL: 
https://chromium-review.googlesource.com/c/chromium/src/+/972741
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8298dd1e563e5124b09805526534e2ec51ef26a

commit e8298dd1e563e5124b09805526534e2ec51ef26a
Author: edchin <edchin@chromium.org>
Date: Wed Mar 21 16:30:03 2018

[ios] Merge tab grid experimental flag into UIRefresh Phase1 flag

Bug:  818560 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic201866380d80d40fa967a2f52342c9c81f656c2
Reviewed-on: https://chromium-review.googlesource.com/972741
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544730}
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/app/tests_fake_hook.mm
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/app/tests_hook.h
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/browser/ui/tab_grid/tab_grid_egtests_hook.mm
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_eg_tests_hook.mm
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/browser/ui/ui_feature_flags.cc
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/browser/ui/ui_feature_flags.h
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/browser/ui/ui_util.h
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/browser/ui/ui_util.mm
[modify] https://crrev.com/e8298dd1e563e5124b09805526534e2ec51ef26a/ios/chrome/test/earl_grey/eg_tests_hook.mm

Comment 8 by edchin@chromium.org, Mar 22 2018

Status: Fixed (was: Started)

Sign in to add a comment