New issue
Advanced search Search tips

Issue 818558 link

Starred by 2 users
Status: Fixed
Owner:
robertma@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 736177
issue 819701
issue 819851



Sign in to add a comment

webkitpy.common.system.platform_info.PlatformInfo.is_hidpi fails on Mac >= 10.12

Project Member Reported by robertma@chromium.org, Mar 5 2018 
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py?type=cs&q=is_highdpi+f:webkitpy&l=75

`system_profiler SPDisplaysDataType` no longer prints a "Retina: Yes" line in the output. Instead, it says:
      Displays:
        Color LCD:
          Display Type: Built-In Retina LCD
          Resolution: 2880 x 1800 Retina

Hence, is_hidpi always returns False on Mac >= 10.12.

Besides, our Mac Retina bots are really running 10.12 instead of 10.11 despite their names (this is issue 818524). Hence, the mac-retina baselines are never used and the retina bots simply use the mac-mac10.12 baselines instead. This issue wasn't caught partly because we haven't run the retina tester for a while on the waterfall for some reason ( https://crbug.com/818301#c11 ).

Comment 1 by qyears...@chromium.org, Mar 7 2018

Blocking: 819701

Comment 2 by robertma@chromium.org, Mar 8 2018

Blocking: 819851

Comment 3 by qyears...@chromium.org, Mar 8 2018

Blocking: 736177
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f895c9b7d06f076579131afadcf1fcac2086615c

commit f895c9b7d06f076579131afadcf1fcac2086615c
Author: Robert Ma <robertma@chromium.org>
Date: Sat Mar 10 01:41:34 2018

Fix Mac Retina detection and reenable some previously disabled tests

Starting from 10.12, system_profiler no longer contains the line
"Retina: Yes" (or No), so we need to detect Retina by looking at the
Resolution field instead.

Besides, we now realize that our Retina bots are actually running 10.12
(despite their names saying 10.11, which will be fixed in other CLs),
so Retina is changed to fall back to Mac 10.12 instead of 10.11.

Lastly, rebaseline.

Bug:  818558 ,  819851 
Change-Id: Ie3ed6ef7d090590f411a1701b72be920498c9769
Reviewed-on: https://chromium-review.googlesource.com/957306
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542306}
[modify] https://crrev.com/f895c9b7d06f076579131afadcf1fcac2086615c/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/f895c9b7d06f076579131afadcf1fcac2086615c/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/css2.1/t1202-counter-04-b-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/css2.1/t1202-counter-04-b-expected.txt
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/css2.1/t1202-counters-04-b-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/css2.1/t1202-counters-04-b-expected.txt
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/editing/deleting/delete-line-006-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/battery-status/battery-full-manual.https-expected.txt
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/block/positioning/047-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/formmove3-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/month/month-appearance-l10n-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/number/number-appearance-spinbutton-layer-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/search/search-display-none-cancel-button-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/search/search-display-none-cancel-button-expected.txt
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/select/003-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/select/select-background-none-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/text/input-spaces-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/forms/text/textfield-overflow-by-value-update-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/invalid/014-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/replaced/replaced-breaking-mixture-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/color-emoji-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/complex-preferred-logical-widths-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/emoticons-expected.png
[add] https://crrev.com/f895c9b7d06f076579131afadcf1fcac2086615c/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/selection/flexbox-selection-expected.png
[add] https://crrev.com/f895c9b7d06f076579131afadcf1fcac2086615c/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/selection/flexbox-selection-nested-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/text/unicode-fallback-font-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/text-combine-various-fonts-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/fonts/sans-serif-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/http/tests/misc/bad-charset-alias-expected.txt
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/inspector-protocol/layout-fonts/ogham-expected.txt
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/inspector-protocol/layout-fonts/tifinagh-expected.txt
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/media/video-zoom-controls-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1-SE/painting-marker-06-f-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/svg/text/text-selection-fonts-01-t-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla/bugs/bug194024-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla/bugs/bug28928-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/tables/mozilla/other/move_row-expected.png
[delete] https://crrev.com/470ff7ff522a1613d567a6aad3e66c1fb7aeb008/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu-rasterization/images/color-profile-image-filter-all-expected.png
[modify] https://crrev.com/f895c9b7d06f076579131afadcf1fcac2086615c/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/prefer_compositing_to_lcd_text/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers-expected.png
[modify] https://crrev.com/f895c9b7d06f076579131afadcf1fcac2086615c/third_party/WebKit/Tools/Scripts/webkitpy/common/system/platform_info.py
[modify] https://crrev.com/f895c9b7d06f076579131afadcf1fcac2086615c/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac.py

Comment 5 by robertma@chromium.org, Mar 12 2018

Owner: robertma@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment