New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818556 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Factory: pytest wireless_antenna fails if two APs with same SSID detected.

Project Member Reported by youcheng@chromium.org, Mar 5 2018

Issue description

Factory Repo: ToT

Currently, pytest 'wireless_antenna' will fail if it detects two or more APs with the same desired SSID.
However, it's possible that there are multiple lines in the factory and working simultaneously.
And forcing each line to use different SSIDs will be a trouble.
We can just keep the WiFi with strongest signal strength and discard the others to resolve this issue.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 5 2018

Labels: merge-merged-factory-scarlet-10211.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/c33b3cd3bd6ee5b945bd1224a1aef028a1380c9f

commit c33b3cd3bd6ee5b945bd1224a1aef028a1380c9f
Author: You-Cheng Syu <youcheng@chromium.org>
Date: Mon Mar 05 06:00:57 2018

wireless_antenna: Report the service with maximum signal strength.

It's possible that there are multiple lines working simultaneously in
the factory. There might be more than one AP with the same desired SSID,
and forcing each AP to use a different SSID will be a trouble.

Therefore, we shouldn't just fail when detecting multiple services with
the same SSID. We could just report the one with maximum signal
strength.

BUG= chromium:818556 
TEST=manually

Change-Id: Ie65b076dd6245be705f667f0e0b422c1d6d4ad65
Reviewed-on: https://chromium-review.googlesource.com/948227
Reviewed-by: Shen-En Shih <petershih@chromium.org>
Commit-Queue: Youcheng Syu <youcheng@chromium.org>
Tested-by: Youcheng Syu <youcheng@chromium.org>
Trybot-Ready: Youcheng Syu <youcheng@chromium.org>

[modify] https://crrev.com/c33b3cd3bd6ee5b945bd1224a1aef028a1380c9f/py/test/pytests/wireless_antenna.py

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/9be4c1f9b09075743f5d35ed204a5d334fdbf34d

commit 9be4c1f9b09075743f5d35ed204a5d334fdbf34d
Author: You-Cheng Syu <youcheng@chromium.org>
Date: Thu Mar 08 00:55:21 2018

wireless_antenna: Report the service with maximum signal strength.

It's possible that there are multiple lines working simultaneously in
the factory. There might be more than one AP with the same desired SSID,
and forcing each AP to use a different SSID will be a trouble.

Therefore, we shouldn't just fail when detecting multiple services with
the same SSID. We could just report the one with maximum signal
strength.

BUG= chromium:818556 
TEST=manually

Change-Id: Ie65b076dd6245be705f667f0e0b422c1d6d4ad65
Reviewed-on: https://chromium-review.googlesource.com/948226
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Youcheng Syu <youcheng@chromium.org>
Reviewed-by: Shen-En Shih <petershih@chromium.org>

[modify] https://crrev.com/9be4c1f9b09075743f5d35ed204a5d334fdbf34d/py/test/pytests/wireless_antenna.py

Status: Fixed (was: Started)

Sign in to add a comment