According yosin@'s suggestion, EditorCommand.cpp is big now and have many static functions. We may want to make static functions into group by introducing static-only class.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64c6dc07ede9edb3d74b7587660303b236ba07be commit 64c6dc07ede9edb3d74b7587660303b236ba07be Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Fri Mar 09 06:35:01 2018 Introduce ClipboardCommands to split EditorCommand.cpp This Cl introduces "ClipboardCommands.h", move the declarations of some static functions related to clipboard to the header file. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I2ebbd4ebb6a0ee3cc13f3a928c786a8d6e285bf4 Reviewed-on: https://chromium-review.googlesource.com/952744 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542052} [modify] https://crrev.com/64c6dc07ede9edb3d74b7587660303b236ba07be/third_party/WebKit/Source/core/editing/BUILD.gn [add] https://crrev.com/64c6dc07ede9edb3d74b7587660303b236ba07be/third_party/WebKit/Source/core/editing/commands/ClipboardCommands.h [modify] https://crrev.com/64c6dc07ede9edb3d74b7587660303b236ba07be/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/272c44bb6de584b3d09352e86e076bd7d9d59414 commit 272c44bb6de584b3d09352e86e076bd7d9d59414 Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Tue Mar 20 04:22:58 2018 Split ClipboardCommands static-only functions out of EditorCommand.cpp This CL introduce "ClipboardCommand.cpp" with moving |ClipboardCommands| member into it. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Icede39fc714367fe57e886f0f9ef23e1989f7518 Reviewed-on: https://chromium-review.googlesource.com/948243 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544280} [modify] https://crrev.com/272c44bb6de584b3d09352e86e076bd7d9d59414/third_party/WebKit/Source/core/editing/BUILD.gn [add] https://crrev.com/272c44bb6de584b3d09352e86e076bd7d9d59414/third_party/WebKit/Source/core/editing/commands/ClipboardCommands.cpp [modify] https://crrev.com/272c44bb6de584b3d09352e86e076bd7d9d59414/third_party/WebKit/Source/core/editing/commands/ClipboardCommands.h [modify] https://crrev.com/272c44bb6de584b3d09352e86e076bd7d9d59414/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b03f7f6c2a11b6e621c26c7ebc07b91de7f7b77 commit 1b03f7f6c2a11b6e621c26c7ebc07b91de7f7b77 Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Mon Mar 26 09:08:29 2018 Introduce InsertCommands to split EditorCommand.cpp This CL introduces "InsertCommands.h", move the declarations of some static functions related to insert commands to the header file. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I4fc744dc58da885071760ba691baa03e8015d63c Reviewed-on: https://chromium-review.googlesource.com/977365 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545746} [modify] https://crrev.com/1b03f7f6c2a11b6e621c26c7ebc07b91de7f7b77/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/1b03f7f6c2a11b6e621c26c7ebc07b91de7f7b77/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp [add] https://crrev.com/1b03f7f6c2a11b6e621c26c7ebc07b91de7f7b77/third_party/WebKit/Source/core/editing/commands/InsertCommands.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bc8fd3d7e3435f52863ce6c57b1ac2d7b2dd5de commit 8bc8fd3d7e3435f52863ce6c57b1ac2d7b2dd5de Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Tue Mar 27 08:13:30 2018 Move InsertCommands to InsertCommands.cpp from EditorCommand.cpp. This CL introduce "InsertCommands.cpp" with moving |InsertCommands| member into it. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ic1fbdccc3c451fc1ad113b3db22cd704fbc21e04 Reviewed-on: https://chromium-review.googlesource.com/981714 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546058} [modify] https://crrev.com/8bc8fd3d7e3435f52863ce6c57b1ac2d7b2dd5de/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/8bc8fd3d7e3435f52863ce6c57b1ac2d7b2dd5de/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp [add] https://crrev.com/8bc8fd3d7e3435f52863ce6c57b1ac2d7b2dd5de/third_party/WebKit/Source/core/editing/commands/InsertCommands.cpp [modify] https://crrev.com/8bc8fd3d7e3435f52863ce6c57b1ac2d7b2dd5de/third_party/WebKit/Source/core/editing/commands/InsertCommands.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bea046658b5831475267682d49507b581efc906d commit bea046658b5831475267682d49507b581efc906d Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Wed Mar 28 04:16:54 2018 Introduce MoveCommands to split EditorCommand.cpp This CL introduces "MoveCommands.h", move the declarations of some static functions related to move commands to the header file. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ia1f9d51876a8b61e1eb720c3d58799aed4929d3f Reviewed-on: https://chromium-review.googlesource.com/981971 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546395} [modify] https://crrev.com/bea046658b5831475267682d49507b581efc906d/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/bea046658b5831475267682d49507b581efc906d/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp [add] https://crrev.com/bea046658b5831475267682d49507b581efc906d/third_party/WebKit/Source/core/editing/commands/MoveCommands.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e81fb3fa2ef212f8e4b2cfec2d7ea91c18a5272c commit e81fb3fa2ef212f8e4b2cfec2d7ea91c18a5272c Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Wed Mar 28 09:05:58 2018 Move MoveCommands to MoveCommands.cpp from EditorCommand.cpp. This CL introduce "MoveCommands.cpp" with moving |MoveCommands| member into it. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I1501b829d1a503aeac7d66005095aeb640bdaf7e Reviewed-on: https://chromium-review.googlesource.com/983201 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546440} [modify] https://crrev.com/e81fb3fa2ef212f8e4b2cfec2d7ea91c18a5272c/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/e81fb3fa2ef212f8e4b2cfec2d7ea91c18a5272c/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp [add] https://crrev.com/e81fb3fa2ef212f8e4b2cfec2d7ea91c18a5272c/third_party/WebKit/Source/core/editing/commands/MoveCommands.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a62b4777e4474a567b188bddf648439966845aea commit a62b4777e4474a567b188bddf648439966845aea Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Thu Mar 29 09:33:13 2018 Introduce StyleCommands to split EditorCommand.cpp This CL introduces "StyleCommands.h" to move the declarations of some static functions related to style commands to the header file to make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Ic30cfa48855dbb482a92d2d2e2d657a9cdfb7ae7 Reviewed-on: https://chromium-review.googlesource.com/985596 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#546779} [modify] https://crrev.com/a62b4777e4474a567b188bddf648439966845aea/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/a62b4777e4474a567b188bddf648439966845aea/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp [add] https://crrev.com/a62b4777e4474a567b188bddf648439966845aea/third_party/WebKit/Source/core/editing/commands/StyleCommands.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e55511b973443310bd0bbe65edff19139e3a9ece commit e55511b973443310bd0bbe65edff19139e3a9ece Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Mon Apr 02 06:33:58 2018 Move StyleCommands to StyleCommands.cpp from EditorCommand.cpp. This CL introduce "StyleCommands.cpp" with moving |StyleCommands| member into it. Make EditorCommand simpler for improving code health. Bug: 818552 Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Icb9a4f48ec4855d178e7b2932cc7f1bc7eef6666 Reviewed-on: https://chromium-review.googlesource.com/987652 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547419} [modify] https://crrev.com/e55511b973443310bd0bbe65edff19139e3a9ece/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/e55511b973443310bd0bbe65edff19139e3a9ece/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp [add] https://crrev.com/e55511b973443310bd0bbe65edff19139e3a9ece/third_party/WebKit/Source/core/editing/commands/StyleCommands.cpp [modify] https://crrev.com/e55511b973443310bd0bbe65edff19139e3a9ece/third_party/WebKit/Source/core/editing/commands/StyleCommands.h
Comment 1 by zhuoyu.q...@samsung.com
, Mar 5 2018Components: Blink>Editing>Command
Status: Available (was: Untriaged)